Thanks Łukasz. Should the solution be documented (in Beam testing guide ?) so that other performance tests can support manual triggering without affecting benchmark results in a similar manner ?
- Cham On Thu, Nov 22, 2018 at 4:03 AM Łukasz Gajowy <lukasz.gaj...@gmail.com> wrote: > Hi all, > > BEAM-6011 is now resolved. If any of you think your changes require such > additional build/performance checks, now you can run them by posting a > comment on Github (eg. "Run Direct Runner Nexmark Tests") to see if > everything is fine before merging a PR. > > Łukasz > > śr., 7 lis 2018 o 17:38 Andrew Pilloud <apill...@google.com> napisał(a): > >> My concern is that PR triggered runs should not publish results to the >> same table as runs on master. Looks like you already covered that in the >> bug. >> >> There is also the issue that there is only one jenkins executor that can >> run the local runner jobs. This will only be a problem if the manual runs >> become frequent. >> >> Andrew >> >> On Wed, Nov 7, 2018, 8:32 AM Łukasz Gajowy <lgaj...@apache.org wrote: >> >>> Hi, >>> >>> recent experience with Nexmark crashes made enabling Phrase Triggering >>> in Nexmark suites even more urgent. If you have any opinions in this area >>> feel free to share them. >>> >>> Here's the link to a corresponding JIRA issue: >>> https://issues.apache.org/jira/browse/BEAM-6011 >>> >>> Łukasz >>> >>
