Some options: - You could wait to assert until after p.waitForFinish(). - You could PAssert using SerializableMatcher and allow any lastModifiedTime.
On Tue, Jan 22, 2019 at 3:56 PM Alex Amato <ajam...@google.com> wrote: > +Jeff, Eugene, > > Hi Jeff and Eugene, > > I've noticed that Jeff's PR > <https://github.com/apache/beam/commit/410d6c7b5f933dcb0280894553c1e576ee4e4884> > introduced > a race condition in this test, but its not clear exactly how to add Jeff's > test check in a thread safe way. I believe this to be the source of the > flakeyness Do you have any suggestions Eugene (since you authored this > test)? > > I added some details to this JIRA issue explaining in full > https://jira.apache.org/jira/browse/BEAM-6491?filter=-2 > > > On Tue, Jan 22, 2019 at 3:34 PM Alex Amato <ajam...@google.com> wrote: > >> I've seen this fail in a few different PRs for different contributors, >> and its causing some issues during the presubmit process.. This is a >> multithreadred test with a lot of sleeps, so it looks a bit suspicious as >> the source of the problem. >> >> https://builds.apache.org/job/beam_PreCommit_Java_Commit/3688/testReport/org.apache.beam.sdk.io/FileIOTest/testMatchWatchForNewFiles/ >> >> I filed a JIRA for this issue: >> https://jira.apache.org/jira/browse/BEAM-6491?filter=-2 >> >> >>
smime.p7s
Description: S/MIME Cryptographic Signature
