Thanks for digging up the PR. I'm still confused as to why that magic number is still there though. Why is there an expectation that the timestamp from the timer is *exactly *1774ms past BoundedWindow.TIMESTAMP_MIN_VALUE?
On Tue, Jan 22, 2019 at 10:43 AM Kenneth Knowles <k...@google.com> wrote: > The commit comes from this PR: https://github.com/apache/beam/pull/2273 > > Kenn > > On Tue, Jan 22, 2019 at 10:21 AM Sam Rohde <sro...@google.com> wrote: > >> Hi all, >> >> Does anyone have context why there is a magic number of "1774" >> milliseconds in the ParDoTest.java on line 2618? This is in >> the testEventTimeTimerAlignBounded method. >> >> File at master: >> https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java#L2618 >> >> First added commit: >> https://github.com/apache/beam/commit/4f934923d28798dfe7cd18c86ff4bcf8eebc27e5 >> >> Regards, >> Sam >> >
