Agree, spotbugs brings static checks that aren't covered in error-prone, it's a good addition. There are few conflicts between error-prone and spotbugs, for instance, the approach to enum switch exhaustiveness, but it can be configured.
On Thu, Jan 31, 2019 at 10:53 AM Ismaël Mejía <ieme...@gmail.com> wrote: > Not a blocker but there is not a spotbugs plugin for IntelliJ. > > On Thu, Jan 31, 2019 at 10:45 AM Ismaël Mejía <ieme...@gmail.com> wrote: > > > > YES PLEASE let's move to spotbugs ! > > Findbugs has not had a new release in ages, and does not support Java > > 11 either, so this will address another possible issue. > > > > On Thu, Jan 31, 2019 at 8:28 AM Kenneth Knowles <k...@apache.org> wrote: > > > > > > Over the last few hours I activated findbugs on the Dataflow Java > worker and fixed or suppressed the errors. They started around 60 but > fixing some uncovered others, etc. You can see the result at > https://github.com/apache/beam/pull/7684. > > > > > > It has convinced me that findbugs still adds value, beyond errorprone > and nullaway/checker/infer. Quite a few of the issues were not nullability > related, though nullability remains the most obvious low-hanging fruit > where a different tool would do even better than findbugs. I have not yet > enable "non null by default" which exposes 100+ new bugs in the worker, at > minimum. > > > > > > Are there known blockers for upgrading to spotbugs so we are depending > on an active project? > > > > > > Kenn > -- Cheers, Gleb
