Hi guys, I just submitted the PR: https://github.com/apache/beam/pull/7751. It
contains refactorings, tests
improvements/fixes and production code fixing.
I wanted to give a little feedback because replacing the mock by a real
instance allowed to - improve the tests: fix bad
tests- add missing split test - and more important to discover a bug in the
production code of the split and fix it.
=> So I would love if we all agree to avoid mocks when possible. Of course, as
mentioned, some times mocks cannot be
avoided e.g. for hosted backends.
Etienne
Le lundi 28 janvier 2019 à 11:16 +0100, Etienne Chauchot a écrit :
> Guys,
> I will try using mocks where I see it is needed. As there is a current PR
> opened on Cassandra, I will take this
> opportunity to add the embedded cassandra server
> (https://github.com/jsevellec/cassandra-unit) to the UTests.Ticket
> was opened while ago: https://issues.apache.org/jira/browse/BEAM-4164
> Etienne
> Le mardi 22 janvier 2019 à 09:26 +0100, Robert Bradshaw a écrit :
> > On Mon, Jan 21, 2019 at 10:42 PM Kenneth Knowles <k...@google.com> wrote:
> > Robert - you meant this as a mostly-automatic thing that we would engineer,
> > yes?
> > Yes, something like TestPipeline that buffers up the pipelines andthen
> > executes on class teardown (details TBD).
> > A lighter-weight fake, like using something in-process sharing a Java
> > interface (versus today a locally running
> > service sharing an RPC interface) is still much better than a mock.
> > +1
> >
> > Kenn
> > On Mon, Jan 21, 2019 at 7:17 AM Jean-Baptiste Onofré <j...@nanthrax.net>
> > wrote:
> > Hi,
> > it makes sense to use embedded backend when:
> > 1. it's possible to easily embed the backend2. when the backend is
> > "predictable".
> > If it's easy to embed and the backend behavior is predictable, then itmakes
> > sense.In other cases, we can fallback to
> > mock.
> > RegardsJB
> > On 21/01/2019 10:07, Etienne Chauchot wrote:Hi guys,
> > Lately I have been fixing various Elasticsearch flakiness issues in
> > theUTests by: introducing timeouts, countdown
> > latches, force refresh,embedded cluster size decrease ...
> > These flakiness issues are due to the embedded Elasticsearch not copingwell
> > with the jenkins overload. Still, IMHO I
> > believe that havingembedded backend for UTests are a lot better than mocks.
> > Even if theyare less tolerant to load, I
> > prefer having UTests 100% representative ofreal backend and add
> > countermeasures to protect against jenkins overload.
> > WDYT ?
> > Etienne
> >
> >
> > --Jean-Baptiste Onofréjbonofre@apache.orghttp://blog.nanthrax.netTalend -
> > http://www.talend.com
