Thank you all for the validations. I sent out RC2 with a fix to BEAM-6697. This affects Java artifacts but Python artifacts are same for both RCs. Please help with validating RC2.
Thank you! On Mon, Feb 25, 2019 at 3:49 PM Charles Chen <c...@google.com> wrote: > +1. I tested Python 3 support in batch and streaming mode (using > wordcount and streaming wordcount) on both DirectRunner and DataflowRunner. > > On Mon, Feb 25, 2019 at 7:54 AM Łukasz Gajowy <lgaj...@apache.org> wrote: > >> Hi, >> >> https://issues.apache.org/jira/browse/BEAM-6697 Is this issue a release >> blocker? I'm asking because performance tests are not part of the release >> verification checklist. (Should they be?) >> >> The issue seems to be related to `google_cloud_bigdataoss_version` change >> (1.9.0 -> 1.9.12) >> >> Łukasz >> >> pon., 25 lut 2019 o 11:08 Maximilian Michels <m...@apache.org> napisał(a): >> >>> +1 (binding) >>> >>> On 25.02.19 03:44, Konstantinos Katsiapis wrote: >>> > +1 >>> > >>> > We (TFX <http://www.tensorflow.org/tfx>) are really looking forward >>> to >>> > the Python 3 compatibility that Apache Beam 2.11 brings. The 2.11 >>> > release will allow several of our existing Apache Beam based libraries >>> > like TensorFlow Data Validation >>> > <https://pypi.org/project/tensorflow-data-validation/>, TensorFlow >>> > Transform <https://pypi.org/project/tensorflow-transform> and >>> TensorFlow >>> > Model Analysis <https://pypi.org/project/tensorflow-model-analysis> >>> to >>> > be Python 3 Compatible (since they are already Python 3 "Ready" and as >>> > such blocked on this release). >>> > >>> > Thanks, >>> > Gus >>> > >>> > On Fri, Feb 22, 2019 at 7:08 PM Reuven Lax <re...@google.com >>> > <mailto:re...@google.com>> wrote: >>> > >>> > +1 (binding) >>> > >>> > On Fri, Feb 22, 2019 at 5:09 PM Robert Bradshaw < >>> rober...@google.com >>> > <mailto:rober...@google.com>> wrote: >>> > >>> > +1 (binding) >>> > >>> > I verified the artifacts for correctness, as well as one of the >>> > wheels >>> > on simple pipelines (Python 3). >>> > >>> > >>> > On Sat, Feb 23, 2019 at 1:01 AM Kenneth Knowles < >>> k...@apache.org >>> > <mailto:k...@apache.org>> wrote: >>> > > >>> > > +1 (binding) >>> > > >>> > > Kenn >>> > > >>> > > On Fri, Feb 22, 2019 at 3:51 PM Ahmet Altay < >>> al...@google.com >>> > <mailto:al...@google.com>> wrote: >>> > >> >>> > >> >>> > >> >>> > >> On Fri, Feb 22, 2019 at 3:46 PM Kenneth Knowles >>> > <k...@apache.org <mailto:k...@apache.org>> wrote: >>> > >>> >>> > >>> I believe you need to sign & hash the Python wheels. The >>> > instructions is unfortunately a bit hidden in the release guide >>> > without an entry in the table of contents: >>> > >> >>> > >> >>> > >> Done, thank you for the pointer. >>> > >> >>> > >>> >>> > >>> >>> > >>> "Once all python wheels have been staged dist.apache.org >>> > <http://dist.apache.org>, please run >>> > ./sign_hash_python_wheels.sh to sign and hash python wheels." >>> > >>> >>> > >>> On Fri, Feb 22, 2019 at 8:40 AM Ahmet Altay >>> > <al...@google.com <mailto:al...@google.com>> wrote: >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> On Fri, Feb 22, 2019 at 1:32 AM Robert Bradshaw >>> > <rober...@google.com <mailto:rober...@google.com>> wrote: >>> > >>>>> >>> > >>>>> It looks like >>> > >>> https://github.com/apache/beam/blob/release-2.11.0/build.gradle >>> > >>>>> differs from the copy in the release source tarball >>> (line >>> > 22, and some >>> > >>>>> whitespace below). Other than that, the artifacts and >>> > signatures look >>> > >>>>> good. >>> > >>>> >>> > >>>> >>> > >>>> Thank you. I fixed the issue (please take a look again). >>> > The difference was due to >>> > https://issues.apache.org/jira/browse/BEAM-6726. >>> > >>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> On Fri, Feb 22, 2019 at 9:50 AM Ahmet Altay >>> > <al...@google.com <mailto:al...@google.com>> wrote: >>> > >>>>> > >>> > >>>>> > Hi everyone, >>> > >>>>> > >>> > >>>>> > Please review and vote on the release candidate #1 for >>> > the version 2.11.0, as follows: >>> > >>>>> > >>> > >>>>> > [ ] +1, Approve the release >>> > >>>>> > [ ] -1, Do not approve the release (please provide >>> > specific comments) >>> > >>>>> > >>> > >>>>> > The complete staging area is available for your >>> review, >>> > which includes: >>> > >>>>> > * JIRA release notes [1], >>> > >>>>> > * the official Apache source release to be deployed to >>> > dist.apache.org <http://dist.apache.org> [2], which is signed >>> > with the key with fingerprint >>> > 64B84A5AD91F9C20F5E9D9A7D62E71416096FA00 [3], >>> > >>>>> > * all artifacts to be deployed to the Maven Central >>> > Repository [4], >>> > >>>>> > * source code tag "v2.11.0-RC1" [5], >>> > >>>>> > * website pull request listing the release [6] and >>> > publishing the API reference manual [7]. >>> > >>>>> > * Python artifacts are deployed along with the source >>> > release to the dist.apache.org <http://dist.apache.org> [2]. >>> > >>>>> > * Validation sheet with a tab for 2.11.0 release to >>> > help with validation [8]. >>> > >>>>> > >>> > >>>>> > The vote will be open for at least 72 hours. It is >>> > adopted by majority approval, with at least 3 PMC affirmative >>> votes. >>> > >>>>> > >>> > >>>>> > Thanks, >>> > >>>>> > Ahmet >>> > >>>>> > >>> > >>>>> > [1] >>> > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12344775 >>> > >>>>> > [2] >>> https://dist.apache.org/repos/dist/dev/beam/2.11.0/ >>> > >>>>> > [3] >>> https://dist.apache.org/repos/dist/release/beam/KEYS >>> > >>>>> > [4] >>> > >>> https://repository.apache.org/content/repositories/orgapachebeam-1061/ >>> > >>>>> > [5] https://github.com/apache/beam/tree/v2.11.0-RC1 >>> > >>>>> > [6] https://github.com/apache/beam/pull/7924 >>> > >>>>> > [7] https://github.com/apache/beam-site/pull/587 >>> > >>>>> > [8] >>> > >>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=542393513 >>> > >>>>> > >>> > >>> > >>> > >>> > -- >>> > Gus Katsiapis | Software Engineer |katsia...@google.com >>> > <mailto:katsia...@google.com> | 650-918-7487 >>> >>