I've been looking at these recently, but I've opted to leave some stuff to Robert. I'm happy to pick them back up if we're looking to reduce the load on a single one : ) Best -P.
On Tue, Mar 12, 2019 at 5:29 PM Alex Amato <[email protected]> wrote: > Hi, > > Mikhail, Ryan and I have been working on some metric related PRs recently. > Robert has been reviewing and committing these changes, but we would like > another reviewer to get another opinion and reduce the volume for Robert. > > Ryan's goal is to implement the GetMetrics API > <https://docs.google.com/document/d/1p7mRCUEigkrWickqCLCHBshrqQ97YIv1E5cZxJTKx3I/edit?ouid=113939718880580928184&usp=docs_home&ths=true> > and > enable querying for metrics in the Flink Runner. > > Mikhail and I are finishing adding some standard metrics for the python > SDK and the Dataflow Runner, and writing integration tests (SDK metrics > design <https://s.apache.org/beam-fn-api-metrics>): > > - Element Count > - MeanByteCount > - User Distribution Metrics > > Please let us know if you would be interested in learning more about > metrics and get involved in reviewing the related PRs and we can add you as > a reviewer. > > Relevant PRs; > https://github.com/apache/beam/pull/7936 > https://github.com/apache/beam/pull/7995 > https://github.com/apache/beam/pull/8032 > https://github.com/apache/beam/pull/7971 > https://github.com/apache/beam/pull/7915 > https://github.com/apache/beam/pull/7899 > > >
