Absolutely :) I took this opportunity for a general reminder. Thanks again for taking this Kotlin example to completion.
On Fri, Apr 12, 2019 at 1:24 PM Pablo Estrada <[email protected]> wrote: > I've merged via a squashed commit that references Jira and the PR. That > should be reasonable? > Best > -P. > > On Fri, Apr 12, 2019, 12:22 PM Ankur Goenka <[email protected]> wrote: > >> Thanks Pablo and Harshit. >> >> Just a quick reminder, please squash the "fixup" sort of commits in the >> PR based on the prior discussion on the mailing list >> https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E >> >> On Fri, Apr 12, 2019 at 11:58 AM Pablo Estrada <[email protected]> >> wrote: >> >>> I've merged this here: https://github.com/apache/beam/pull/8291 >>> >>> Thanks for all who took a look, and to Harshit for the contribution. : ) >>> >>> On Thu, Apr 4, 2019 at 10:30 PM Jean-Baptiste Onofré <[email protected]> >>> wrote: >>> >>>> Thanks for the update Pablo. >>>> >>>> I will try to take a look during the week end. >>>> >>>> Regards >>>> JB >>>> >>>> On 04/04/2019 23:16, Pablo Estrada wrote: >>>> > Hello all, >>>> > as community member has been very kind to contribute a Kotlin >>>> > translation of the WordCount pipeline[1]. The documentation, tests, >>>> and >>>> > gradle structure for it is very good, so I am happy to merge, but >>>> since >>>> > this code will become our first Kotlin "documentation"/entrypoint, I >>>> > wanted to be cautious. >>>> > So if anyone wants to take a look to review the change, please do. I >>>> > will merge this in a couple days. >>>> > Thanks! >>>> > -P. >>>> > >>>> > [1] https://github.com/apache/beam/pull/8034 >>>> >>>> -- >>>> Jean-Baptiste Onofré >>>> [email protected] >>>> http://blog.nanthrax.net >>>> Talend - http://www.talend.com >>>> >>>
