Agree that "just import learnings/kata/java" sounds right. Is there any build that checks the content so that changes in Beam do not break it?
Kenn On Fri, May 17, 2019 at 2:19 AM Michael Luckey <adude3...@gmail.com> wrote: > Hi Henry, > > unfortunately I do not know how to give advice here. I would first need to > better understand the semantics. > > What I recommend we should do, is to add some documentation first. As > starting point, we might just copy some of the info given on the PR [1]. I > d say, those are worth to be added to that subproject readme. We need to > ensure that some dev knows what to do with this module. > > Regarding the inclusion of Gradle wrapper et all. there might be technical > reasons to do so. So I would expect, that with the current setup I am able > to just import that learnings/kata/java into my IDE and it just works. That > seems to be not the case. Maybe I did something wrong here. > > So I am wondering, how to actually use this structure. If we need to add > some build step and/or some course.json we probably need to improve here > also? > > Maybe the coming blog post will answer my questions. > > Best, > > michel > > [1] https://github.com/apache/beam/pull/8358 > > On Thu, May 16, 2019 at 5:11 PM Henry Suryawirawan < > hsuryawira...@google.com> wrote: > >> Hi Michael, >> >> I initially started the Kata as a standalone project, which I then >> contributed as-is to the repository. >> Please advise me if there is any guideline on how to set it up better. >> >> One note from me is that due to the way how JetBrains Education work, the >> project might only work if it is loaded as a root project. >> It also has a corresponding .idea/study_project.xml that needs to exist >> for the metadata so that it can load properly. >> >> >> >> >> *From: *Michael Luckey <adude3...@gmail.com> >> *Date: *Thu, May 16, 2019 at 9:34 PM >> *To: *dev >> >> Sorry, missed the link [1] >>> >>> [1] https://github.com/apache/beam/tree/master/learning/katas/java >>> >>> >>> >>> On Thu, May 16, 2019 at 3:32 PM Michael Luckey <adude3...@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> I just learned, that the newly merged learning/kata/java is setup as >>>> full fledged root project [1]. >>>> >>>> Is this intentional? If so, should we provide some documentation on the >>>> whys? >>>> >>>
