Hi Etienne,
I saw that too while working on solving [1]. It seems a little weird and
I was a little tempted to changed it to something roughly equivalent to
Combine.perKey with single key. But, actually the Combine.globally
should be rather small, right? There will be single value for each
window. And even if we change it to Combine.perKey with single key I
think the problem of potential OOM will be just moved to some worker. Or
would you see some other option?
Jan
[1] https://issues.apache.org/jira/browse/BEAM-7574
On 6/27/19 11:43 AM, Etienne Chauchot wrote:
Hi guys,
FYI, while I'm working on the combine translation for the new spark
runner poc, I saw something that do not seem right in the current
runner: https://issues.apache.org/jira/browse/BEAM-7647
Best,
Etienne