@Udi Meiri <[email protected]> I did some research and reached out to Scott. It seems that the new plugin doesn't support phrase triggering and Jenkins Job DSL that we use to create jobs doesn't support it either. I don't see a simple way to overcome problems related to the deactivation of ghprb plugin. I'm going to be unavailable for the next week, so if anyone else wants to take the JIRA issue, feel free to do it. Have a good weekend
Michal On Fri, Jul 12, 2019 at 5:11 PM Michał Walenia <[email protected]> wrote: > Thanks for the heads up, I'll get in touch with him so that I don't > duplicate the research. > > > On Fri, Jul 12, 2019 at 3:55 PM Lukasz Cwik <[email protected]> wrote: > >> I believe Scott Wegner investigated the new plugin (about 10 months ago) >> because it seemed like it could filter out running tests based upon paths >> but it was lacking some other feature(s) that the old plugin had that we >> were already using. >> >> On Fri, Jul 12, 2019 at 4:52 AM Katarzyna Kucharczyk < >> [email protected]> wrote: >> >>> Just for knowledge sharing purpose, here is a link to conversation >>> <https://lists.apache.org/thread.html/0a0cdb7ef91754ae78dd228359266f979a60778b336918ab7720f18f@%3Cbuilds.apache.org%3E> >>> about the new plugin. >>> >>> Kasia >>> >>> On Fri, Jul 12, 2019 at 10:47 AM Michał Walenia < >>> [email protected]> wrote: >>> >>>> Hi, >>>> I think I'd like to take a look at it. I'll assign the issue to myself >>>> and I'll keep you posted on my findings. >>>> >>>> Have a good day >>>> >>>> Michal >>>> >>>> On Thu, Jul 11, 2019 at 8:10 PM Udi Meiri <[email protected]> wrote: >>>> >>>>> Opened https://issues.apache.org/jira/browse/BEAM-7725 for migration >>>>> off the old plugin onto the new (already deprecated I might add) plugin. >>>>> Any takers? >>>>> >>>>> On Thu, Jul 11, 2019 at 10:53 AM Udi Meiri <[email protected]> wrote: >>>>> >>>>>> Okay, phrase triggering is working again (they re-enabled the >>>>>> plugin). See notes in bug for details. >>>>>> >>>>>> On Thu, Jul 11, 2019 at 10:04 AM Udi Meiri <[email protected]> wrote: >>>>>> >>>>>>> I've opened a bug: https://issues.apache.org/jira/browse/BEAM-7723 >>>>>>> If anyone is working on this please assign yourself >>>>>>> >>>>>>> On Wed, Jul 10, 2019 at 5:57 PM Udi Meiri <[email protected]> wrote: >>>>>>> >>>>>>>> Thanks Kenn. >>>>>>>> >>>>>>>> On Wed, Jul 10, 2019 at 3:31 PM Kenneth Knowles <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Just noticed this thread. Infra turned off one of the GitHub >>>>>>>>> plugins - the one we use. I forwarded the announcement. I'll see if >>>>>>>>> we can >>>>>>>>> get it back on for a bit so we can migrate off. I'm not sure if they >>>>>>>>> have >>>>>>>>> identical job DSL or not. >>>>>>>>> >>>>>>>>> On Wed, Jul 10, 2019 at 12:32 PM Udi Meiri <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Still happening for me too. >>>>>>>>>> >>>>>>>>>> On Wed, Jul 10, 2019 at 10:40 AM Lukasz Cwik <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> This has happened in the past. Usually there is some issue where >>>>>>>>>>> Jenkins isn't notified of new PRs by Github or doesn't see the PR >>>>>>>>>>> phrases >>>>>>>>>>> and hence Jenkins sits around idle. This is usually fixed after a >>>>>>>>>>> few hours >>>>>>>>>>> without any action on our part. >>>>>>>>>>> >>>>>>>>>>> On Wed, Jul 10, 2019 at 10:28 AM Katarzyna Kucharczyk < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi all, >>>>>>>>>>>> >>>>>>>>>>>> Hope it's not duplicate but I can't find if any issue with >>>>>>>>>>>> phrase triggering in Jenkins was already here. >>>>>>>>>>>> Currently, I started third PR and no test were triggered there. >>>>>>>>>>>> I tried to trigger some tests manually, but with no effect. >>>>>>>>>>>> >>>>>>>>>>>> Am I missing something? >>>>>>>>>>>> >>>>>>>>>>>> Here are links to my problematic PRs: >>>>>>>>>>>> https://github.com/apache/beam/pull/9033 >>>>>>>>>>>> https://github.com/apache/beam/pull/9034 >>>>>>>>>>>> https://github.com/apache/beam/pull/9035 >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Kasia >>>>>>>>>>>> >>>>>>>>>>> >>>> >>>> -- >>>> >>>> Michał Walenia >>>> Polidea <https://www.polidea.com/> | Software Engineer >>>> >>>> M: +48 791 432 002 <+48791432002> >>>> E: [email protected] >>>> >>>> Unique Tech >>>> Check out our projects! <https://www.polidea.com/our-work> >>>> >>> > > -- > > Michał Walenia > Polidea <https://www.polidea.com/> | Software Engineer > > M: +48 791 432 002 <+48791432002> > E: [email protected] > > Unique Tech > Check out our projects! <https://www.polidea.com/our-work> > -- Michał Walenia Polidea <https://www.polidea.com/> | Software Engineer M: +48 791 432 002 <+48791432002> E: [email protected] Unique Tech Check out our projects! <https://www.polidea.com/our-work>
