Hi All,

This is my first attempt at a change for Beam on 
https://issues.apache.org/jira/browse/BEAM-7819.  This parses the message_id 
when reading from the PubSub protobuf and adds to the message_id, as suggested 
by the existing documentation - 
https://beam.apache.org/releases/pydoc/2.13.0/apache_beam.io.gcp.pubsub.html#apache_beam.io.gcp.pubsub.PubsubMessage.attributes


My code is currently checked into my fork:- 
https://github.com/matt-darwin/beam/tree/BEAM-7819-parse-pubsub-message_id


Prior to creating a pull request, I just wanted to check the approach is 
sensible and then to go through the process for pull request to ensure it goes 
smoothly.  I do wonder if long term despite the documentation indicated this 
would be part of the attributes property it might be more sensible to fully 
mimic the protobuf for the PubSub message.

Kind regards

Matthew

Disclaimer

The information contained in this communication from the sender is 
confidential. It is intended solely for use by the recipient and others 
authorized to receive it. If you are not the recipient, you are hereby notified 
that any disclosure, copying, distribution or taking action in relation of the 
contents of this information is strictly prohibited and may be unlawful.

This email has been scanned for viruses and malware, and may have been 
automatically archived by Mimecast Ltd, an innovator in Software as a Service 
(SaaS) for business. Providing a safer and more useful place for your human 
generated data. Specializing in; Security, archiving and compliance. To find 
out more visit the Mimecast website.

Reply via email to