+1

I installed from source, and ran unit tests for Python in 2.7, 3.5, 3.6.

Also ran a number of integration tests on Py 3.5 on Dataflow and
DirectRunner.
Best
-P.

On Tue, Jul 30, 2019 at 11:09 AM Hannah Jiang <hannahji...@google.com>
wrote:

> I checked Py3 tests using .zip, mainly with direct runners, and everything
> looks good, so +1.
>
> On Tue, Jul 30, 2019 at 2:08 AM Robert Bradshaw <rober...@google.com>
> wrote:
>
>> I checked all the artifact signatures and ran a couple test pipelines
>> with the wheels (Py2 and Py3) and everything looked good to me, so +1.
>>
>> On Mon, Jul 29, 2019 at 8:29 PM Valentyn Tymofieiev <valen...@google.com>
>> wrote:
>>
>>> I have checked Python 3 batch and streaming quickstarts on Dataflow
>>> runner using .zip and wheel distributions. So far +1 from me.
>>>
>>> On Mon, Jul 29, 2019 at 7:53 PM Ahmet Altay <al...@google.com> wrote:
>>>
>>>> +1, validated python 2 quickstarts.
>>>>
>>>> On Fri, Jul 26, 2019 at 5:46 PM Ahmet Altay <al...@google.com> wrote:
>>>>
>>>>> To confirm, I manuall validated leader board on python. It is working.
>>>>>
>>>>> On Fri, Jul 26, 2019 at 5:23 PM Yifan Zou <yifan...@google.com> wrote:
>>>>>
>>>>>> AFAIK, there should not be any special prerequisites for this. Things
>>>>>> the script does including:
>>>>>> 1. download the python rc in zip
>>>>>> 2. start virtualenv and install the sdk.
>>>>>> 3. verify hash.
>>>>>> 4. config settings.xml and start a Java pubsub message injector.
>>>>>> 5. run game examples and validate.
>>>>>>
>>>>>> Could you double check if the sdk was installed properly (step 1&2)?
>>>>>>
>>>>>
>>>>> I also guessing this is the case. Probably something earlier in the
>>>>> validation script did not run as expected.
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>> Yifan
>>>>>>
>>>>>> On Fri, Jul 26, 2019 at 2:38 PM Anton Kedin <ke...@google.com> wrote:
>>>>>>
>>>>>>> Validation script fails for me when I try to run [1] python
>>>>>>> leaderboard with direct runner:
>>>>>>>
>>>>>>> ```
>>>>>>> *****************************************************
>>>>>>> * Running Python Leaderboard with DirectRunner
>>>>>>> *****************************************************
>>>>>>> /usr/bin/python: No module named apache_beam.examples.complete.game
>>>>>>> ```
>>>>>>>
>>>>>>> If someone has more context, what are the prerequisites for this
>>>>>>> step? How does it look up the module?
>>>>>>>
>>>>>>> [1]
>>>>>>> https://github.com/apache/beam/blob/master/release/src/main/scripts/run_rc_validation.sh#L424
>>>>>>>
>>>>>>> Regards,
>>>>>>> Anton
>>>>>>>
>>>>>>> On Fri, Jul 26, 2019 at 10:23 AM Anton Kedin <ke...@google.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Cool, will make the post and will update the release guide as well
>>>>>>>> then
>>>>>>>>
>>>>>>>> On Fri, Jul 26, 2019 at 10:20 AM Chad Dombrova <chad...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> I think the release guide needs to be updated to remove the
>>>>>>>>>> optionality of blog creation and avoid confusion. Thanks for 
>>>>>>>>>> pointing that
>>>>>>>>>> out.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>>

Reply via email to