+1 It is completely worth it. On Tue, Jul 30, 2019 at 8:50 PM Rui Wang <ruw...@google.com> wrote:
> +1. > > I did something similar before: move TestBoundedTable to BeamSQL main to > allow another module tests use it. > > > -Rui > > On Tue, Jul 30, 2019 at 6:13 PM Pablo Estrada <pabl...@google.com> wrote: > >> Hello all, >> I found some test utilities that we use to write unit tests for >> transforms that read/write to/from BigQuery. These are all the >> non-(*IT.java/*Test.java) classes in [1]. >> >> I believe that users may want to write tests for their own pipelines that >> may rely on complex DynamicDestination logic (imagine streaming, or side >> inputs for on-the-fly schema computation, or other tricky issues). >> >> I think it makes sense to move these classes to >> org.apache.beam.io.gcp.bigquery.testing, and publish them in the release. >> Thoughts? >> >> -P. >> >> [1] >> https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery >> >
