Another useful thing to improve Java 11 support is to add Automatic-Module-Name headers to the various JARs Beam publishes:
https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md If a JAR doesn't include this, Java synthezizes one from the name of the jar file, and things get wonky fast. This is a low risk change that has no effect on non-modular and pre-Java-9 apps. On Wed, Aug 7, 2019 at 9:41 AM Michał Walenia <[email protected]> wrote: > Hi everyone, > > I want to gather the collective knowledge here about Java 11 compatibility > and ask about the tests needed to deem Beam compatible with JDK 11. > > Right now concerning testing JDK 11 compatibility I implemented: > > - Jenkins jobs for running ValidatesRunner test sets in both Direct > and Dataflow runners, [1], [2] > - ValidatesRunner portability API tests for Dataflow [3], > - examples in normal and portable mode for the Dataflow runner [4], > [5]. > > > Are these tests sufficient to say that we’re java 11 compatible? What > other aspects do we need to test to be able to say that? > > > Regards, > > > Michał > > [1] > https://builds.apache.org/job/beam_PostCommit_Java11_ValidatesRunner_Direct/ > [2] > https://builds.apache.org/job/beam_PostCommit_Java11_ValidatesRunner_Dataflow/ > [3] > https://builds.apache.org/job/beam_PostCommit_Java11_ValidatesRunner_PortabilityApi_Dataflow/ > [4] > https://builds.apache.org/job/beam_PostCommit_Java11_Examples_Dataflow/ > [5] > https://builds.apache.org/job/beam_PostCommit_Java11_Examples_Dataflow_Portability/ > > -- > > Michał Walenia > Polidea <https://www.polidea.com/> | Software Engineer > > M: +48 791 432 002 <+48791432002> > E: [email protected] > > Unique Tech > Check out our projects! <https://www.polidea.com/our-work> > -- Elliotte Rusty Harold [email protected]
