Cool, sounds like we're getting closer to the same page. Some more replies below.
On Fri, Aug 23, 2019 at 1:47 PM Ning Kang <ni...@google.com> wrote: > Thanks for the feedback, Robert! I think I got your idea. > Let me summarize it to see if it’s correct: > 1. You want everything about > > standard Beam concepts > > to follow existing pattern: so we can shot down create_pipeline() and > keep the InteractiveRunner notion when constructing pipeline, I agree with > it. A runner can delegate another runner, also agreed. Let’s keep it that > way. > Despite everything I've written, I'm not convinced that exposing this as a Runner is the most intuitive way to get interactivity either. Given that the "magic" of interactivity is being able to watch PCollections (for inspection and further construction), and if no PCollecitons are watched execution proceeds as normal, what are your thoughts about making all pipelines "interactive" and just doing the magic iff there are PCollections to watch? (The opt-in incantation here would be ibeam.watch(globals()) or similar.) FWIW, Flume has something similar (called marking collections as to be materialized). It has its pros and cons. > 2. watch() and visualize() can be in the independent interactive beam > module since they are > > concepts that are unique to being interactive > > 3. I'll add some example for the run_pipeline() in design doc. The short > answer is run_pipeline() != p.run(). Thanks for sharing the doc ( > https://s.apache.org/no-beam-pipeline). > As described in the doc, when constructing the pipeline, we still want to > bundle a runner and options to the constructed pipeline even in the future. > So if the runner is InteractiveRunner, the interactivity instrument > (implicitly applied read/write cache PTransform and input/output wiring) is > only applied when "run_pipeline()" of the runner implementation is invoked. > p.run() will apply the instrument. However, this static function > run_pipeline() takes in a new runner and options, > invoking “run_pipeline()” implementation of the new runner and wouldn’t > have the instrument, thus no interactivity. > Because you cannot (don’t want to, as seen in the doc, users cannot access > the bundled pipeline/options in the future) change the runner easily > without re-executing all the notebook cells, this shorthand function allows > a user to run pipeline without interactivity immediately anywhere in a > notebook. In the meantime, the pipeline is still bundled with the original > Interactive Runner. The users can keep developing further pipelines. > The usage of this function is not intuitive until you put it in a notebook > user scenario where users develop, test in prod-like env and develop > further. And it’s equivalent to users writing > "from_runner_api(to_runner_api(pipeline))” in their notebook. It’s just a > shorthand. > What you're trying to work around here is the flaw in the existing API that a user binds the choice of Runner before pipeline construction, rather than at the point of execution. I propose we look at fixing this in Beam itself. 4. And we both agree that implicit cache is palatable and should be the > only thing we use to support interactivity. Cache and watched pipeline > definition (which tells us what to cache) are the main “hidden state” I > meant. Because the cache mechanism is totally implicit and hidden from the > user. A cache is either read or written in a p.run(). If an existing cache > is not used in a p.run(), it expires. If the user restarts the IPython > kernel, all cache should expire too. > Depending on how we label items in the cache, they could survive kernel restarts as well. This relates to another useful feature in Beam where if a batch pipeline fails towards the end, one may want to resume/rerun it from there after fixing the bug without redoing all the work. > 5. I think my explanation of focusing on Direct Runner is misleading. > 5.1 My implementation of instrumenting pipeline with cache and wiring > input/output is runner agnostic. I never access the underlying runner or > options when instrumenting the pipeline. Underlying runner is only used > when run_pipeline(). It's just I'm not appending PTransform (implicit > read/write cache) and re-wiring input/output by directly modifying a > portable proto. I’m doing it directly to a pipeline object (which is > bundled with InteractiveRunner with some underlying runner) and > AppliedPTransform nodes. > 5.2 Caching is more like a way to optimize pipeline execution and > materialize PCollection data for visualization. Re-evaluating the whole > pipeline every time can also give users interactive experience. > 5.3 So yes, I > > don't think the "interactive experience should be tailored for different > underlying runners.” > > The caching mechanism / the magic that helps the interactivity > instrumenting process might need different implementation for different > underlying runners. Because the runner can be anywhere deployed in any > architecture, the notebook is just a process on a machine. They need to > work together. > Currently, we have the local file based cache. If we run a pipeline > with underlying_runner as DataflowRunner, we’ll need something like GCS > based cache. An in-memory cache might be runner agnostic, but it might > explode with big data source. > Yep, we need filesystem/directory to use as a cache. We have an existing temp_location flag that we can use for this (and is required for distributed runners). If unset we can default to a local temp dir (which works for the direct runner). > Existing InteractiveRunner has the following portability > <https://github.com/apache/beam/tree/master/sdks/python/apache_beam/runners/interactive#portability>. > That’s why I said the interactivity (implementation) needs to be tailored > for different underlying runners. > If we allow users to pass in all kinds of underlying runners (even > their in-house ones), we have to support the interactivity for all of them > which we probably don't. That’s why we wanted a create_pipeline() wrapper > so that in notebook, when building a pipeline, bundle to DirectRunner by > default. > The focus on the Direct Runner is also related to our objective: we > want to provide easy-to-use notebook and some notebook environment where > users can interactively execute pipelines without worrying about setup > (especially when the setup is not Beam but Interactive Beam related). > 6. We don’t fix typo for user defined transforms > > I'm talking about pruning like having a cell with > > pcoll | beam.Map(lambda x: expression_with_typo) > > and then fixing it (and re-evaluating) with > > pcoll | beam.Map(lambda x: expression_with_typo_fixed) > > where the former Map would *always* fail and never get removed from the > pipeline. > > We never change the pipeline defined by the user. Interactivity is applied > to a copy of user defined pipeline. > Sure. But does the executed (copy) of the pipeline contain the bad Map operation in it? If so, it in essence "poisons" the entire pipeline, forcing a user to re-create and re-define it from the start to make forward progress (which results in quite a poor user experience--the errors in cell N manifest in cell M, but worse fixing and re-executing cell N doesn't fix cell M). If not, how is it intelligently excluded (and in a way that is not too dis-similar from non-interactive mode, and doesn't cause surprises with the p.run vs. run_pipeline difference)? > 7. > > One approach was that the pipeline construction is re-executed every time > (i.e the "pipeline" object to run is really a callback, like a callable or > a PTransform) and then there's no ambiguity here. > > I didn’t quite get it. Pipeline construction only happens when a user > executes a cell with the pipeline construction code. > Are you suggesting changing the logic in pipeline.apply() to always > reapply/replace a NamedPTransform? I don’t think we (Interactive Beam) can > decide that because it changes the behavior of Beam. > We had some thought of subclassing pipeline and use the create_pipeline() > method to create the subclassed pipeline object. Then intercept the > pipeline.apply() to always replace PTransform with existing full label and > apply logic of parent pipeline’s apply() logic. > It seems to be a no go to me now. > Sorry I wasn't clear. I'm referring to the style in the above doc about getting rid of the Pipeline object (as a long-lived thing at least). In this case the actual execution of pipeline construction never spans multiple cells (though its implementation might via function calls) so one never has out-of-date transforms dangling off the pipeline object. > This has the downsides of recreating the PCollectiion objects which are > being used as handles (though perhaps they could be re-identified). > > If a user re-executes a cell with PCollection = p | PTransform, the > PCollection object will be a new instance. That is not a downside. > We can keep the existing behavior of Beam to always raise an error when > the cell with named PTransform is re-executed. > > Thanks! > > Ning. > > > > On Aug 23, 2019, at 11:36 AM, Robert Bradshaw <rober...@google.com> wrote: > > On Wed, Aug 21, 2019 at 3:33 PM GMAIL <kawai...@gmail.com> wrote: > >> Thanks for the input, Robert! >> >> On Aug 21, 2019, at 11:49 AM, Robert Bradshaw <rober...@google.com> >> wrote: >> >> On Wed, Aug 14, 2019 at 11:29 AM Ning Kang <ni...@google.com> wrote: >> >>> Ahmet, thanks for forwarding! >>> >>> >>>> My main concern at this point is the introduction of new concepts, even >>>> though these are not changing other parts of the Beam SDKs. It would be >>>> good to see at least an alternative option covered in the design document. >>>> The reason is each additional concept adds to the mental load of users. And >>>> also concepts from interactive Beam will shift user's expectations of Beam >>>> even though there are not direct SDK modifications. >>> >>> >>> Hi Robert. About the concern, I think I have a few points: >>> >>> 1. *Interactive Beam (or Interactive Runner) is already an existing >>> "new concept" that normal Beam user could opt-in if they want an >>> interactive Beam experience.* They need to do lots of setup steps >>> and learn new things such as Jupyter notebook and at least >>> interactive_runner module to make it work and make use of it. >>> >>> I think we should start with the perspective that most users interested >> in using Beam interactively already know about Jupyter notebooks, or at >> least ipython, and would want to use it to learn (and more effectively use) >> Beam. >> >> Yes, I agree with the perspective for users who are familiar with >> notebook. Yet it doesn’t prevent us from creating ready-to-use containers >> (such as binder <https://github.com/jupyterhub/binderhub>) for users >> who want to try Beam interactively without setting up a environment with >> all the dependencies interactive Beam introduces. I agree that experienced >> users understand how to set up additional dependencies and read examples, >> it’s just we are also targeting other entry level audiences. >> But back to the original topic, the design is not trying to add new >> concept, but fixing some rough edges of existing Interactive Beam features. >> We can discuss whether a factory of create_pipeline() is really desired and >> decide whether to expose it later. We hope the interactive_beam module to >> be the only module an Interactive Beam user would directly invoke in their >> notebook. >> > > My goal would be that one uses a special interactive module for those > concepts that are unique to being interactive, and standard Beam concepts > (rather than replacements or wrappers) otherwise. > >> >>> 1. *The behavior of existing interactive Beam is different from >>> normal Beam because of the interactive nature and the users would expect >>> that.* And the users wouldn't shift their expectation of normal >>> Beam. Just like running Python scripts might result in different behavior >>> than running all of them in an interactive Python session. >>> >>> I'm not quite following this. One of the advantages strengths of Python >> is that lack of the difference between the interactive vs. non-interactive >> behavior. (The fact that a script's execution is always in top to bottom >> order, unlike a notebook, is the primary difference.) >> >> Sorry for the confusion. What I’m saying is about the hidden states. >> Running several Python scripts from top to bottom in an IPython session >> might generate different effects than running them in the same order >> normally. Say if you have an in-memory global configuration that is shared >> among all the scripts and if it’s missing, a script initializes one. >> Running the scripts in IPython will pass the initialization and >> modification of configuration along the scripts. While running the scripts >> one by one will initialize different configurations. Running cells in a >> notebook is equivalent to appending the cells into a script and run it. The >> interactivity is not about the order, but if there is hidden states >> preserved between each statement or each script execution. And the users >> should expect that there might be hidden states when they are in an >> interactive environment because that is exactly the interactivity they >> expect. However, they don’t hold the hidden states, the session does it for >> them. A user wouldn’t need to explicitly say “preserve the variable x I’ve >> defined in this cell because I want to reuse it in some other cells I’m >> going to execute”. The user can directly access variable x once the cell >> defining x is executed. And even if the user deletes the cell defining x, x >> still exists. At that stage, no one would know there is a variable x in >> memory by just looking at the notebook. One would see a missing execution >> sequence (on top left of each executed cell) and wonder where the piece of >> code executed goes. >> Above is just for interactivity, not Beam. >> > > You can have interactive without hidden state (e.g. the iPython console) > notebooks are very common (and useful). IMHO, we should try to avoid > leveraging hidden state when possible as it makes things difficult to > reason about (even for those used to it). Things like implicit caches are > more palatable because (generally, there's issues with side effects and > non-determinism) the behavior remains the same (but performance, and > consequently user experience, is augmented). > > The crux of interactive Beam seems instead to be that one can inspect the > contents of PCollections after they have run, and apply further operations > to these PCollections which, when executed, will (generally) not re-execute > previously completed operations (i.e. incremental, interactive pipeline > construction). These two properties can be leveraged in a script just as > well as a notebook and have nothing to do with hidden state (in the > notebook sense). > > Another interesting thing is that a named PTransform cannot be applied to >> the same pipeline more than once. It means a cell with named PTransform: p >> | “Name” >> NamedPTransform() cannot be re-executed. We might want to >> support such re-execution if the pipeline is in an interactive mode. In >> that case, the Beam behavior might be different from non-interactive Beam. >> > > Yes, this is could be a critical difference, which if we go this route > makes me think the "InteractivePipeline" which differs from the standard > Pipeline may make sense if we go down this route. More below. > >> >>> 1. Or if a user runs a Beam pipeline with direct runner, they should >>> expect the behavior be different from running it on Dataflow while a user >>> needs GCP account. I think the users are aware of the difference when >>> they >>> choose to use Interactive Beam. >>> >>> The central, defining tenant of Beam is that behavior should be >> consistent across different runners. Of course there are operational >> details that are difficult, or perhaps even undesirable, to align (like, as >> you mention, needing a GCP account for running on Dataflow, or providing >> the location of the master when running Flink). But even these should be >> minimized (see the recent efforts to make the temp location a standard >> rather than dataflow-specific option). >> >> We should, however, attempt to minimize gratuitous differences. In >> particular, we should make it as easy as possible to transition (in terms >> of code, docs, and developers) between interactive and non-interactive. >> >> Yes, I agree that runners should be consistent. The interactive runner we >> currently have is a wrapper of its underlying runner. Thus we don’t intend >> to brand it as a standalone runner. And that’s why we want to create an >> interactive_beam module for end users to avoid confusing them with a new >> runner called InteractiveRunner. >> > > *This* seems to be the crux of the argument, that Interactive should not > be a Runner, but something else. Exactly what that something else has not > yet been well defined. > > >> And I want to focus on direct runner as underlying runner for now. >> > > It's fine to only use the direct runner for now; it's certainly a lot > easier. But can you confirm there's nothing about the Direct runner itself > that you're depending on to implement this (or if there is something, > clearly document it here). > > >> Because with the portability of Beam, when applying interactivity to >> original pipeline, we can always do: pipeline_with_runner_A -> portable >> proto -> pipeline_with_direct_runner -> apply interactivity and get a new >> pipeline -> new portable proto -> pipeline_with_runner_A with interactivity. >> > > I think there's some conflation of concepts here (which are reflected in > the rest of this conversation). > > In the Beam model, the Runner is not a property of a Pipeline. Rather a > Pipeline is passed to a Runner for execution. (Along with some options.) > > On the other hand, Python's Pipeline object currently holds an instance of > a Runner (for historical reasons). This is something we'd like to remove > (as we did in Java, or at least we removed the ability to reference and > query the Pipeline's Runner). This mismatch in the model vs the API was one > of the motivations for https://s.apache.org/no-beam-pipeline . > > From an implementation perspective, I would strongly discourage having the > intermediate representation be "pipeline_with_direct_runner" that's derived > from a portable proto. The implementation details of that class are > il-defined, subject to change, and I hope will in the not-to-distant future > be removed (or at least significantly cleaned up), and don't work well for > things like cross-language pipelines. > > >> And the run_pipeline() feature is exactly the transition from interactive >> to non-interactive. >> With p.run(), one has to re-built/re-execute the pipeline p from the >> beginning. While they can do p -> portable proto -> >> pipeline_with_their_desired_runner_no_interactivity in a subsequent cell. >> The run_pipeline() is a shorthand for the process. It’s about the same >> thing we want to decide for create_pipeline(): do we leave the boilerplate >> one-liner to the users and what would the level of the users be for their >> first time playing with Beam? >> We never mutate the p defined by the user so p by itself is always >> non-interactive. Only when p.run() is invoked, interactivity is applied. >> > > I am not following this at all. interactive_beam.run_pipeline(p) is not > p.run()? But it is the latter that is interactive, not the former? Maybe > some examples would help--there aren't any in the doc. > > >> >> >>> 1. *Our design actually reduces the mental load of interactive Beam >>> users with intuitive interactive features*: create pipeline, >>> visualize intermediate PCollection, run pipeline at some point with other >>> runners and etc. For example, right now, the user needs to use a more >>> complicated set of libraries, like creating a Beam pipeline with >>> interactive runner that needs an underlying runner fed in. We are >>> getting >>> rid of it. An interactive Beam user shouldn't be concerned about the >>> underlying interactive magic. >>> >>> I agree a user shouldn't be concerned about the implementation details, >> but I fail to see how >> >> p = interactive_module.create_pipeline() >> >> is significantly simpler than, or preferable to, >> >> p = Pipeline(interactive_module.InteractiveRunner()) >> >> especially as the latter is in line with non-interactive pipelines (and >> all our examples, docs, etc.) Now, perhaps an argument could be made that >> interactivity is not a property of the runner, but something orthogonal to >> that, e.g. one should write >> >> p = InteractivePipeline() >> >> or >> >> p = Pipeline(options, interactive=True) >> >> or similar. (It was introduced as a runner because, conceptually, a >> runner is something that takes a pipeline and executes it.) >> >> Yeah, this is debatable. I think the difference is, we want to introduce >> something that is Interactive Beam but not Interactive Runner. >> > > Gotcha. > > >> I really wish that we have a 4runner standard thingy that can be >> implemented to intercept the pipeline for any runner before the execution. >> > > Any runner that does delegation to another runner *is* a standard thingy > that can intercept the pipeline for any runner before the execution. (One > may want translation of results on the other end as well.) But it can be > argued that this is not the most intuitive API. > > In that case, the wrapped interactive logic can be just a function that is >> applicable to existing runner in some interactive mode with >> “interactive=True”. But we don’t intend to introduce the new concept. >> >> p = interactive_module.create_pipeline() >> >> is saying the pipeline is created with interactivity and runnable in >> notebook. You can still convert the pipeline for other runners without >> interactivity. >> There is no guarantee that the interactivity is provided by (direct) >> runner nor any of the underlying implementation is backward compatible. >> There is no implementation details exposed in the API. You can even treat >> it as using this library, one can create a pipeline with direct runner but >> with interactivity as additional feature. >> I would favor the composition way. >> >> p = Pipeline(interactive_module.InteractiveRunner()) >> >> is saying you can create a pipeline with this new runner thingy and we’ll >> maintain the runner forever like other runners. >> Additionally it can even take in an underlying runner. But does it make >> sense for a runner to take another runner? Is this applicable to all >> runners? >> > > This is similar to Guava's filtering and transforming collection wrappers. > > >> The implementation details is exposed in the API itself while users don’t >> care about and we don’t want to maintain. >> >> p = Pipeline(options, interactive=True) >> >> is saying Pipeline can have an interactive mode. Like discussed above, >> it’ll be a new concept for the concept “pipeline”. It’s basically saying >> anything pipeline can have an interactive mode. That’s the inheritance way. >> > > Yep. If you already know about Pipelines, it's easy to learn about > interactive Pipelines. Perhaps more importantly, if you already know about > Interactive Pipelines, you now know a bunch about non-interactive ones. > > An even more radical concept would be that an interactive Pipeline is just > one that has any watched PCollections. (In other words, interactive vs. > non-interactive is not a mode or a setting, just something that happens > when you try to use things interactively.) > > >> Does this apply to pipeline created by other runner? >> > > Runners do not create piplines. Runners execute pipelines. Any Runner > should be able to execute any pipeline. > > >> >>> 1. The interactive experience should be tailored for different >>> underlying runners. There is no portability of interactivity and users >>> opt-in interactive Beam using notebook would naturally expect something >>> similar to the direct runner. >>> >>> This concerns me a lot. Again, the core tenant of beam is that one can >> choose the execution environment (runner) completely independently with how >> one writes the pipeline. We should figure out what, if anything, needs to >> be supported by a runner to support interactivity (the only thing that >> comes to mind is a place to read and write temporary/cached data), but I >> very strongly feel we should not go down the road of having different >> interactive apis/experiences for different runners. In particular, the many >> instances to the DirectRunner are worrisome--what's special about the >> DirectRunner that other runners cannot provide that's needed for >> interactive? If we can't come up with a good answer to that, we should not >> impose this restriction. >> >> We don’t intend to provide different interactive experience for different >> runners. >> > > Good, so to clarify, you don't think the "interactive experience should be > tailored for different underlying runners." > > >> >>> 1. *Interactive Beam is solving an orthogonal set of problems than >>> Beam*. You can think of it as a wrapper of Beam that enables >>> interactivity and it's not even a real runner. It doesn't change the Beam >>> model such as how you build a pipeline. And with the Beam portability, >>> you >>> get the capability to run the pipeline built from interactive runner with >>> other runners for free. It adds the interactive behavior that a user >>> expects. >>> 2. *We want to open source it though we can iterate faster without >>> doing it*. The whole project can be encapsulated in a completely >>> irrelevant repository and from a developer's perspective, I want to hide >>> all the implementation details from the interactive Beam user. However, >>> as >>> there is more and more desire for interactive Beam (+Mehran Nazir >>> <mna...@google.com> for more details), we want to share the >>> implementation with others who want to contribute and explore the >>> interactive world. >>> >>> I would much rather see interactivity as part of the Beam project. With >> good APIs the implementations don't have to be tightly coupled (e.g. the >> underlying runner delegation) but I think it will be a better user >> experience if interactive was a mode rather than a wrapper with different >> entry points. >> >> I agree with it when the interactive mode is acknowledged as a >> must-have/common/standard for all runners or for Beam pipeline itself. >> But this will be a new concept that is distributed top-down from Beam to >> its contributors. >> Our current objective is to enable interactivity of Beam in notebook and >> introduce experimental usages/features (and we want to limit the features >> and make them easy to use). >> I like the idea that anyone can write a runner or a transform. I would >> wish that anyone can add interactivity (before, during, or after pipeline >> execution) when it’s a mature concept. >> Maybe in the future, interactivity will be something that is similar to >> accessibility, internationalization, testability and etc. (Like if you >> write a class, you need not only a test but also a notebook to demo it) >> > > The discussions about how to behave with such fundamental concepts such as > applying transforms imply that this is something that can't just be thrown > on top, but may require deeper changes to the API itself. > > >> But we are not doing it right now until we have more feedback from the >> community and concrete CUJs. >> >> >> >> I think watch() is a really good solution to knowing which collections to >> cache, and visualize() will be very useful. >> >> One thing I don't see tackled at all yet is the fact that pipelines are >> only ever mutated by appending on new operations, so some design needs to >> be done in terms of how to remove (possibly error-causing) operations or >> replace bad ones with fixed ones. This is where most of the unsolved >> problems lie. >> >> Thanks! And we haven’t really decided if plotting plain data is a good >> idea for PCollections. Plotting the metadata/analytics/insight might be a >> better option for users. I’m looking into facets >> <https://pair-code.github.io/facets/> that TFX notebook uses. >> > > Yes, there are many different ways one might want to "look at" a > PCollection. > > >> Yes, existing PR <https://github.com/apache/beam/pull/9278> is appending >> operations only. >> We would have pruning when the appended operations severe the whole >> pipeline DAG into a set of DAGs to only execute the part of pipeline that >> needs to be re-executed (optimization). This is included in the design. >> > > I'm talking about pruning like having a cell with > > pcoll | beam.Map(lambda x: expression_with_typo) > > and then fixing it (and re-evaluating) with > > pcoll | beam.Map(lambda x: expression_with_typo_fixed) > > where the former Map would *always* fail and never get removed from the > pipeline. > > >> We could also have the replacing logic that allows users to re-execute a >> cell with named PTransform by replacing the PTransform. >> This needs your precious feedback and is a bug-fix of existing >> interactive beam rather than the design around user-defined Collection >> variables. >> This is actually another debatable topic. Like I said, executing cells in >> notebook is equivalent to appending the code into a script. >> Users can re-execute cells with only anonymous PTransforms. It’s >> equivalent to applying the PTransform many times "in parallel". >> However, users cannot re-execute cells with any named PTransform. The >> inconsistency comes. >> > > Yes, this is a *major* pain point I've seen every time people try to use > Beam in a notebook. On the other hand, differing behaviors here (adding > operations in parallel vs. replacement) could have surprising (non-local!) > effects when moving from interactive to non-interactive mode. > > >> Should the re-execution of named PTransform be supported? When supported, >> should we replace PTransform or append PTransforms "in parallel"? >> I think we’ll eventually pick a route, go through it and see what the >> interactive Beam users provide as feed back. >> > > One approach was that the pipeline construction is re-executed every time > (i.e the "pipeline" object to run is really a callback, like a callable or > a PTransform) and then there's no ambiguity here. This has the downsides of > recreating the PCollectiion objects which are being used as handles (though > perhaps they could be re-identified). > > >> >> >> Also +David Yan <david...@google.com> for more opinions. >>> >>> Thanks! >>> >>> Ning. >>> >>> On Tue, Aug 13, 2019 at 6:00 PM Ahmet Altay <al...@google.com> wrote: >>> >>>> Ning, I believe Robert's questions from his email has not been answered >>>> yet. >>>> >>>> On Tue, Aug 13, 2019 at 5:00 PM Ning Kang <ni...@google.com> wrote: >>>> >>>>> Hi all, I'll leave another 3 days for design >>>>> <https://docs.google.com/document/d/1DYWrT6GL_qDCXhRMoxpjinlVAfHeVilK5Mtf8gO6zxQ/edit?usp=sharing> >>>>> review. >>>>> Then we can have a vote session if there is no objection. >>>>> Thanks! >>>>> >>>>> On Fri, Aug 9, 2019 at 12:14 PM Ning Kang <ni...@google.com> wrote: >>>>> >>>>>> Thanks Ahmet for the introduction! >>>>>> >>>>>> I've composed a design overview >>>>>> <https://docs.google.com/document/d/1DYWrT6GL_qDCXhRMoxpjinlVAfHeVilK5Mtf8gO6zxQ/edit?usp=sharing> >>>>>> describing changes we are making to components around interactive >>>>>> runner. I'll share the document in our email thread too. >>>>>> >>>>>> The truth is since interactive runner is not yet a recognized runner >>>>>> as part of the Beam SDK (and it's fundamentally a wrapper around direct >>>>>> runner), we are not touching any Beam SDK components. >>>>>> We'll not change any behavior of existing Beam SDK and we'll try our >>>>>> best to keep it that way in the future. >>>>>> >>>>> >>>> My main concern at this point is the introduction of new concepts, even >>>> though these are not changing other parts of the Beam SDKs. It would be >>>> good to see at least an alternative option covered in the design document. >>>> The reason is each additional concept adds to the mental load of users. And >>>> also concepts from interactive Beam will shift user's expectations of Beam >>>> even though there are not direct SDK modifications. >>>> >>>> >>>>> >>>>>> In the meantime, I'll work on other components orthogonal to Beam >>>>>> such as Pipeline Display and Data Visualization I mentioned in the design >>>>>> overview. >>>>>> >>>>>> If you have any questions, please feel free to contact me through >>>>>> this email address! >>>>>> >>>>>> Thanks! >>>>>> >>>>>> Regards, >>>>>> Ning. >>>>>> >>>>>> On Wed, Aug 7, 2019 at 5:01 PM Ahmet Altay <al...@google.com> wrote: >>>>>> >>>>>>> Ning, thank you for the heads up. >>>>>>> >>>>>>> All, this is a proposed work for improving interactive Beam >>>>>>> experience. As mentioned in Ning's email, new concepts are being >>>>>>> introduced. And in addition iBeam as a name is used as a new reference. >>>>>>> I >>>>>>> hope that bringing the discussion to the mailing list will give it the >>>>>>> additional visibility and more people could share their feedback. >>>>>>> >>>>>>> (cc'ing a few folks that might be interested +Robert Bradshaw >>>>>>> <rober...@google.com> +Valentyn Tymofieiev <valen...@google.com> +Sindy >>>>>>> Li <qiny...@google.com> +Brian Hulette <bhule...@google.com> ) >>>>>>> >>>>>>> Ahmet >>>>>>> >>>>>>> >>>>>>> On Wed, Aug 7, 2019 at 12:36 PM Ning Kang <ni...@google.com> wrote: >>>>>>> >>>>>>>> To whom may concern, >>>>>>>> >>>>>>>> This is Ning from Google. We are currently making efforts to >>>>>>>> leverage an interactive runner under python beam sdk. >>>>>>>> >>>>>>>> There is already an interactive Beam (iBeam for short) runner with >>>>>>>> jupyter notebook in the repo >>>>>>>> <https://github.com/apache/beam/tree/master/sdks/python/apache_beam/runners/interactive> >>>>>>>> . >>>>>>>> Following the instructions on that page, one can set up an >>>>>>>> interactive environment to develop and execute Beam pipeline >>>>>>>> interactively. >>>>>>>> >>>>>>>> However, there are many issues with existing iBeam. One issue is >>>>>>>> that it uses a concept of leaf PCollection to cache and materialize >>>>>>>> intermediate PCollection. If the user wants to reuse/introspect a >>>>>>>> non-leaf >>>>>>>> PCollection, the interactive runner will run into errors. >>>>>>>> >>>>>>>> Our initial effort will be fixing the existing issues. And we also >>>>>>>> want to make iBeam easy to use. Since iBeam uses the same model Beam >>>>>>>> uses, >>>>>>>> there isn't really any difference for users between creating a pipeline >>>>>>>> with interactive runner and other runners. >>>>>>>> So we want to minimize the interfaces a user needs to learn while >>>>>>>> giving the user some capability to interact with the interactive >>>>>>>> environment. >>>>>>>> >>>>>>>> See this initial PR <https://github.com/apache/beam/pull/9278>, >>>>>>>> the interactive_beam module will provide mainly 4 interfaces: >>>>>>>> >>>>>>>> - For advanced users who define pipeline outside __main__, let >>>>>>>> them tell current interactive environment where they define their >>>>>>>> pipeline: >>>>>>>> watch() >>>>>>>> - This is very useful for tests where pipeline can be >>>>>>>> defined in test methods. >>>>>>>> - If the user simply creates pipeline in a Jupyter notebook >>>>>>>> or a plain Python script, they don't have to know/use this >>>>>>>> feature at all. >>>>>>>> - Let users create an interactive pipeline: create_pipeline() >>>>>>>> - invoking create_pipeline(), the user gets a Pipeline >>>>>>>> object that works as any other Pipeline object created from >>>>>>>> apache_beam.Pipeline() >>>>>>>> - However, the pipeline object p, when invoking p.run(), >>>>>>>> does some extra interactive magic. >>>>>>>> - We'll support interactive execution for DirectRunner at >>>>>>>> this moment. >>>>>>>> - Let users run the interactive pipeline as a normal pipeline: >>>>>>>> run_pipeline() >>>>>>>> - In an interactive environment, a user only needs to add >>>>>>>> and execute 1 line of code run_pipeline(pipeline) to execute any >>>>>>>> existing >>>>>>>> interactive pipeline object as normal pipeline in any selected >>>>>>>> platform. >>>>>>>> - We'll probably support Dataflow only. Other >>>>>>>> implementations can be added though. >>>>>>>> - Let users introspect any intermediate PCollection they have >>>>>>>> handler to: visualize() >>>>>>>> - If a user ever writes pcoll = p | "Some Transform" >> >>>>>>>> some_transform() ..., they can visualize(pcoll) once the >>>>>>>> pipeline p is >>>>>>>> executed. >>>>>>>> - p can be batch or streaming >>>>>>>> - The visualization will be some plot graph of data for the >>>>>>>> given PCollection as if it's materialized. If the PCollection is >>>>>>>> unbounded, >>>>>>>> the graph is dynamic. >>>>>>>> >>>>>>>> The PR will implement 1 and 2. >>>>>>>> >>>>>>>> We'll use https://issues.apache.org/jira/browse/BEAM-7923 as the >>>>>>>> top level JIRA and add blocking JIRAs as development goes. >>>>>>>> >>>>>>>> External Beam users will not worry about any of the underlying >>>>>>>> implementation details. >>>>>>>> Except the 4 interfaces above, they learn and write normal Beam >>>>>>>> code and can execute the pipeline immediately when they are done with >>>>>>>> prototyping. >>>>>>>> >>>>>>>> Ning. >>>>>>>> >>>>>>> >
