Post-commit runs all precommits. The builder for the Jenkins jobs creates separate jobs with suffixes:
* _Commit (for when a commit is pushed to a PR) * _Phrase (for when someone asks to run it) * _Cron (run as a post-commit against master) This way, the different jobs have independent configuration and the post-commit version of them has a clear healthy/unhealthy signal. My preference FWIW would be to use "precommit" and "postcommit" to refer _only_ to when a suite of tests is run and _never_ as part of the name of any suite of tests. There seems to be frequent confusion about things due to the names. That would be a medium size change to gradle configs, Jenkins configs, and cultural. Kenn On Tue, Oct 29, 2019 at 10:41 AM Mikhail Gryzykhin <mig...@google.com> wrote: > IIRC currently, post-commit doesn't run pre-commits. However we have > precommit_cron jobs that run pre-commits periodically. However it sums up > to dozens of jobs that is really hard to monitor. > > If we split things even further, we definitely need to combine result into > something more easily trackable. > > Also making post-commits bigger is not that good idea either, since it > will make them even more flaky and any PR that needs to run them can get > stuck forever. > > Main point is that we want to do some work around improving monitoring, > not simply make more post-commits, or bigger post-commits. > > On Tue, Oct 29, 2019 at 9:56 AM Chad Dombrova <chad...@gmail.com> wrote: > >> >> +1 for splitting pre-commit tests into smaller modules. However in this >>> case we need to run all the small tests periodically and have some combined >>> flag or dashboard for regular monitoring. Otherwise we might not run/check >>> on big amount of tests. >>> >> >> post-commit seems like the best place for that, no? >> >> >> >
