Thanks for the contribution. Happy to help with the review. Also, probably it'll be good to follow patterns employed by the existing Datastore connector when applicable: https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
Thanks, Cham On Mon, Nov 4, 2019 at 2:37 AM Ismaël Mejía <ieme...@gmail.com> wrote: > Hello, > > Please open a PR with the code of the new connector rebased against > the latest master. > > It is worth to take a look at Beam's contribution guide [1] and > PTransform style guide [2] in advance. > In any case we can guide you on any issue during the PR review so > please go ahead. > > Regards, > Ismaël > > [1] https://beam.apache.org/contribute/ > [2] https://beam.apache.org/contribute/ptransform-style-guide/ > > > On Mon, Nov 4, 2019 at 10:48 AM Stefan Djelekar > <stefan.djele...@redbox.com> wrote: > > > > Hi beam devs, > > > > > > > > I'm Stefan from Redbox. We are a customer of GCP and we are in need of > beam Java connector for Firestore. > > > > > > > > There is a pending JIRA item for this. > https://issues.apache.org/jira/browse/BEAM-8376 > > > > > > > > The team inside of the company has been working on this for a while and > we would like to contribute! > > > > What is the best way to do this? Can we perhaps get a review from an > experienced beam member? > > > > Let me know what do you think. > > > > > > > > All the best, > > > > > > > > Stefan Đelekar > > > > Sofware Engineer > > > > stefan.djele...@redbox.com > > > > djelekar.com > > > > >
