Hi,
this may be a dumb question. Let's imagine a hypothetical case, where I
open a pull request against master. I wrote the change on top of COMMIT#11,
so:

My branch:
COMMIT#11 -> MyCommit

Let's suppose that master has received a bunch of new commits (and a fix on
COMMIT#12), so it looks like so:

Master branch:
COMMIT#11->COMMIT#12->COMMIT#13

When I open my PR, I am asking to pull MyCommit on top of COMMIT#13; *but*
when PreCommits run against my PR, they run against my branch, right?

So COMMIT#11->MyCommit.

If I wanted to test my PR with a fix that exists in COMMIT#12, I would have
to rebase My branch to include it.

Is my understanding correct?
Best
-P.

Reply via email to