This was discussed in a JIRA [1] but don't think this was mentioned in the
dev list.

Not having environment_id as a top level attribute of PTransform [2] makes
it difficult to track the Environment [3] a given PTransform should be
executed in. For example, in Dataflow, we have to fork code in several
places to filter out the Environment from a given PTransform proto.

Making environment_id a top level attribute of PTransform and removing it
from various payload types will make tracking environments easier. Also
code will become less error prone since we don't have to fork for all
possible payload types.

Any objections to doing this change ?

Thanks,
Cham

[1] https://issues.apache.org/jira/browse/BEAM-7850
[2]
https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L99
[3]
https://github.com/apache/beam/blob/master/model/pipeline/src/main/proto/beam_runner_api.proto#L1021

Reply via email to