Hi Etienne,
That is hard to tell from the outside. Based on the activity in the PRs,
it looks like you already chose the second PR (#10025).
You should know best which one to merge. Make a call.
Cheers,
Max
On 26.11.19 15:14, Etienne Chauchot wrote:
Hi guys,
I wanted your opinion about something:
I have 2 concurrent PRs that do the same:
https://github.com/apache/beam/pull/10010
https://github.com/apache/beam/pull/10025
The first one is a bit better because it addresses a deprecation that
the other does not address. Except that they are the same. The first one
the the older (1 day before) but the second one is the one that received
reviews.
I guess the problem is that there were 3 duplicate tickets of
Elasticsearch7 upgrade (because people do not search for existing
tickets before opening). As a result concurrent PRs were submitted
despite the PR link on jira. I removed the duplicates but I need to
close one of the PRs.
The question is: which one do you think should be closed?
Thanks for you opinion guys
Etienne
