Ah I'll try to add this tomorrow before going out for the weekend. -P. On Wed, Nov 20, 2019 at 12:15 PM Valentyn Tymofieiev <valen...@google.com> wrote:
> Based on my recent debugging experience for > https://issues.apache.org/jira/browse/BEAM-8651, I think it may be > helpful to include thread IDs, into the log entries, or have an option to > easily enable this. I imagine that having process ID may also be helpful in > other situations. > > On Tue, Nov 19, 2019 at 11:17 AM Chad Dombrova <chad...@gmail.com> wrote: > >> Pablo, it might be necessary to setup a root logging handler if one does >> not exist already. I noticed that a LocalJobServicer that I was testing >> against stopped emitting tracebacks when I rebased onto the latest from >> master. Setting up the root handler fixed it. I'm still testing this, and >> I might be misinterpreting what I saw, but I wanted to get eyes on it in >> case I don't have time to get a definitive answer. >> >> -chad >> >> >> >> On Fri, Nov 15, 2019 at 4:30 PM Pablo Estrada <pabl...@google.com> wrote: >> >>> Thanks all, >>> 2/3 of PRs are merged (using _LOGGER). It should be pretty easy to >>> switch the variable name to _log via sed. >>> Best >>> -P. >>> >>> On Fri, Nov 15, 2019 at 2:08 PM Kyle Weaver <kcwea...@google.com> wrote: >>> >>>> +1 for per-module loggers (what Robert said). >>>> >>>> On Fri, Nov 15, 2019 at 1:48 PM Udi Meiri <eh...@google.com> wrote: >>>> >>>>> +1, but can we use something less verbose and shift key heavy than >>>>> _LOGGER like log or _log? >>>>> >>>>> Also please dedupe with these existing bugs: >>>>> https://issues.apache.org/jira/browse/BEAM-3523 >>>>> https://issues.apache.org/jira/browse/BEAM-1825 >>>>> >>>>> On Thu, Nov 14, 2019 at 8:02 AM Thomas Weise <t...@apache.org> wrote: >>>>> >>>>>> Awesome, thanks Chad! >>>>>> >>>>>> On Wed, Nov 13, 2019 at 10:26 PM Chad Dombrova <chad...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Hi Thomas, >>>>>>> >>>>>>> >>>>>>>> Will this include the ability for users to configure logging via >>>>>>>> pipeline options? >>>>>>>> >>>>>>> >>>>>>> We're working on a proposal to allow pluggable logging handlers that >>>>>>> can be configured via pipeline options. For example, it would allow >>>>>>> you to >>>>>>> add a new logging handler for StackDriver or Elasticsearch. Will >>>>>>> hopefully >>>>>>> have a document to share soon. >>>>>>> >>>>>>> -chad >>>>>>> >>>>>>>
