The `changedir = {envsitepackagesdir}` setting is definitely something I
haven't thought of.
It solves the shadowing issue without needing to split tests and packages
from one another. (though I still think it's unnecessary to include tests
in the published package)IIUC, isolated_build=True and the removal of setup.py invocation in the current virtualenv should eliminate any Cython output files in the repo, and no need for run_tox_cleanup.sh? On Wed, Dec 11, 2019 at 9:38 AM Chad Dombrova <chad...@gmail.com> wrote: > Hi Udi, > >> Sorry I didn't realize you already had a solution for the shadowing issue >> and BEAM-8572. >> > > No worries at all. I haven't had much time to invest into that PR lately > (most of it I did at home on my own time), but I did get past most of the > major issues. You've been working on so many of the same problems I was > trying to solve there, and so far you've been coming to the same > conclusions independently (e.g. removing pytest-runner and > setup_requires). It's great to have that validation, and it's helped > reduce the scope of my PR. Moving forward, I would love to team up on > this. Happy to answer any questions you have about the approach I took. > > -chad > > >
smime.p7s
Description: S/MIME Cryptographic Signature
