Thanks for being transparent about this, Pablo. :) 👍 Best, Łukasz
pt., 13 gru 2019 o 06:32 Kenneth Knowles <k...@apache.org> napisał(a): > Thanks for alerting dev@. > > IMO this was handled perfectly by all parties. > > Kenn > > On Thu, Dec 12, 2019 at 4:09 PM Valentyn Tymofieiev <valen...@google.com> > wrote: > >> The change LGTM, so you can consider it reviewed. In general it would be >> nice to set up alerts to catch these situations, to make sure they don't go >> unnoticed. >> >> Also as a reminder - please don't commit or merge PRs into release >> branches without a review from a release manager. >> >> On Thu, Dec 12, 2019 at 3:44 PM Pablo Estrada <pabl...@google.com> wrote: >> >>> Seed job runs okay: >>> https://builds.apache.org/job/beam_SeedJob_Standalone/3865/console >>> >>> >>> On Thu, Dec 12, 2019 at 3:28 PM Pablo Estrada <pabl...@google.com> >>> wrote: >>> >>>> I accidentally committed a small change to master: >>>> https://github.com/apache/beam/commit/6018326ffe74aac7d8c44ded296b92f8b5c0b556 >>>> >>>> I am verifying that this works as intended for now. >>>> >>>> What should we do about this? Revert? Leave as is if it works fine? >>>> Best >>>> -P >>>> >>>
