Big +1 on it. Thanks a lot for the improvement Udi !
It also make sense to have this timeout for other tests like Max said. I'm thinking whether there are any timeout configurations for Jenkins, in this case, the timeout config could be applied to all tests if necessary. Best, Jincheng Robert Bradshaw <[email protected]> 于2019年12月21日周六 上午7:21写道： > On Fri, Dec 20, 2019 at 3:15 PM Udi Meiri <[email protected]> wrote: > > > > ITs will have a different timeout, but they're still not migrated to > pytest so unaffected at the moment. > > > > So I created a PR and already seemed to find an issue. One test timed > out while scanning the local filesystem. > > It seems that it was scanning /tmp, which for apache-beam-jenkins-9 has > 400k files (test output filenames are like: > /tmp/tmpnv2uyqas.result-chars-00000-of-00001). > > Sounds like something that should be fixed (cleaning up jenkins, and > fixing our tests to clean up after themselves, and requiring expensive > scans of of /tmp). > > Overall huge +1 to setting per-test timeouts. > > > On Fri, Dec 20, 2019 at 9:41 AM Pablo Estrada <[email protected]> > wrote: > >> > >> big +1! > >> > >> As Ahmet suggested, the IT-marked tests may need to have a different > timeout. But other than that, I think this is great. > >> > >> On Fri, Dec 20, 2019 at 9:39 AM Udi Meiri <[email protected]> wrote: > >>> > >>> https://issues.apache.org/jira/browse/BEAM-9009 > >>> > >>> On Fri, Dec 20, 2019 at 6:18 AM Maximilian Michels <[email protected]> > wrote: > >>>> > >>>> +1 Good idea. We should also have this for Java if possible. > >>>> > >>>> On 20.12.19 02:59, Ahmet Altay wrote: > >>>> > This sounds reasonable. Would this be configurable per-test if > needed? > >>>> > > >>>> > On Thu, Dec 19, 2019 at 5:52 PM Udi Meiri <[email protected] > >>>> > <mailto:[email protected]>> wrote: > >>>> > > >>>> > Looking at this console log > >>>> > < > https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/timestamps/?time=HH:mm:ss&timeZone=GMT-8&appendLog&locale=en_US > >, > >>>> > it seems that some pytests got stuck (or slowed down > considerably). > >>>> > I'd like to put a 10 minute default timeout on all unit tests, > using > >>>> > the pytest-timeout <https://pypi.org/project/pytest-timeout/> > plugin. > >>>> > >
