-1
I'm having trouble verifying the signatures on the release artifacts.
When I try to import the key from
https://dist.apache.org/repos/dist/release/beam/KEYS I get
pub rsa4096 2019-10-22 [SC]
79552F5C2FD869A08E097F96841855FB73AFFC7F
uid [ unknown] Mikhail Gryzykhin (mikhail) <mikh...@apache.org>
sub rsa4096 2019-10-22 [E]
which is not the key that these artifacts were signed with.
On Thu, Jan 2, 2020 at 4:23 PM Reuven Lax <re...@google.com> wrote:
>
> +1
>
> On Thu, Jan 2, 2020 at 3:02 PM Valentyn Tymofieiev <valen...@google.com>
> wrote:
>>
>> +1. Validated Batch and Streaming quickstarts on Python 3.7 (using wheels)
>> and Batch Mobile Gaming examples (user score, hourly team score) on Dataflow.
>>
>> On Thu, Jan 2, 2020 at 11:23 AM Ahmet Altay <al...@google.com> wrote:
>>>
>>> This vote needs at least one more PMC vote before it can be finalized.
>>> Could you please validate and vote?
>>>
>>> On Mon, Dec 23, 2019 at 9:44 AM Luke Cwik <lc...@google.com> wrote:
>>>>
>>>> +1, I validated the Java quickstarts for the runners and the issues I have
>>>> brought up have been moved to a future release.
>>>>
>>>> On Fri, Dec 20, 2019 at 8:09 PM Ahmet Altay <al...@google.com> wrote:
>>>>>
>>>>> +1, I validated the python2 quick starts using wheels. Thank you for
>>>>> pushing the release this far.
>>>>>
>>>>> On Thu, Dec 19, 2019 at 1:27 PM Kenneth Knowles <k...@google.com> wrote:
>>>>>>
>>>>>> I verified the Java quickstart on Dataflow manually.
>>>>>>
>>>>>> Kenn
>>>>>>
>>>>>> On Wed, Dec 18, 2019 at 5:58 PM jincheng sun <sunjincheng...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Thanks for drive this release Mikhail !
>>>>>>>
>>>>>>> I have found there is an incorrect release version for release notes in
>>>>>>> PR[1], also left a question in PR[2].
>>>>>>>
>>>>>>> But I do not think it's the blocker of the release :)
>>>>>>>
>>>>>>> Best,
>>>>>>> Jincheng
>>>>>>>
>>>>>>> [1] https://github.com/apache/beam/pull/10401
>>>>>>> [2] https://github.com/apache/beam/pull/10402
>>>>>>>
>>>>>>>
>>>>>>> Ahmet Altay <al...@google.com> 于2019年12月19日周四 上午3:31写道：
>>>>>>>>
>>>>>>>> I validated python quickstarts with python 2. Wheels file are missing
>>>>>>>> but they work otherwise. Once the wheel files are added I will add my
>>>>>>>> vote.
>>>>>>>>
>>>>>>>> On Wed, Dec 18, 2019 at 10:00 AM Luke Cwik <lc...@google.com> wrote:
>>>>>>>>>
>>>>>>>>> I verified the release and ran the quickstarts and found that release
>>>>>>>>> 2.16 broke Apache Nemo runner which is also an issue for 2.17.0 RC
>>>>>>>>> #2. It is caused by a backwards incompatible change in
>>>>>>>>> ParDo.MultiOutput where getSideInputs return value was changed from
>>>>>>>>> List to Map as part of https://github.com/apache/beam/pull/9275. I
>>>>>>>>> filed https://issues.apache.org/jira/browse/BEAM-8989 to track the
>>>>>>>>> issue.
>>>>>>>>>
>>>>>>>>> Should we re-add the method back in 2.17.0 renaming the newly added
>>>>>>>>> method to something else and also patch 2.16.0 with a minor change
>>>>>>>>> including the same fix (breaking 2.16.0 users who picked up the new
>>>>>>>>> method) or leave as is?
>>>>>>>>
>>>>>>>>
>>>>>>>> I suggest not fixing this for 2.17, because the issue already exists
>>>>>>>> in 2.16 and there are two releases in parallel and it would be fine to
>>>>>>>> fix this for 2.18 or 2.19.
>>>>>>>>
>>>>>>>> +Reuven Lax, who merged the mentioned PR.
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Tue, Dec 17, 2019 at 12:13 PM Mikhail Gryzykhin
>>>>>>>>> <mig...@google.com> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi everyone,
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Please review and vote on the release candidate #2 for the version
>>>>>>>>>> 2.17.0, as follows:
>>>>>>>>>>
>>>>>>>>>> [ ] +1, Approve the release
>>>>>>>>>>
>>>>>>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The complete staging area is available for your review, which
>>>>>>>>>> includes:
>>>>>>>>>>
>>>>>>>>>> * JIRA release notes [1],
>>>>>>>>>>
>>>>>>>>>> * the official Apache source release to be deployed to
>>>>>>>>>> dist.apache.org [2], which is signed with the key with fingerprint
>>>>>>>>>> 53F72D4EEEF306D97736FE1065ABB07A8965E788
>>>>>>>>>>
>>>>>>>>>> [3],
>>>>>>>>>>
>>>>>>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>>>>>>>
>>>>>>>>>> * source code tag "v2.17.0-RC2" [5],
>>>>>>>>>>
>>>>>>>>>> * website pull request listing the release [6], publishing the API
>>>>>>>>>> reference manual [7], and the blog post [8].
>>>>>>>>>>
>>>>>>>>>> * Python artifacts are deployed along with the source release to the
>>>>>>>>>> dist.apache.org [2].
>>>>>>>>>>
>>>>>>>>>> * Validation sheet with a tab for 2.17.0 release to help with
>>>>>>>>>> validation [9].
>>>>>>>>>>
>>>>>>>>>> * Docker images published to Docker Hub [10].
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The vote will be open for at least 72 hours. It is adopted by
>>>>>>>>>> majority approval, with at least 3 PMC affirmative votes.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> --Mikhail
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [1]
>>>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345970&projectId=12319527
>>>>>>>>>>
>>>>>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.17.0/
>>>>>>>>>>
>>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
>>>>>>>>>>
>>>>>>>>>> [4]
>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1087/
>>>>>>>>>>
>>>>>>>>>> [5] https://github.com/apache/beam/tree/v2.17.0-RC2
>>>>>>>>>>
>>>>>>>>>> [6] https://github.com/apache/beam/pull/10401
>>>>>>>>>>
>>>>>>>>>> [7] https://github.com/apache/beam-site/pull/594
>>>>>>>>>>
>>>>>>>>>> [8] https://github.com/apache/beam/pull/10402
>>>>>>>>>>
>>>>>>>>>> [9]
>>>>>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=803858785
>>>>>>>>>>
>>>>>>>>>> [10] https://hub.docker.com/u/apachebeam
>>>>>>>>>>
>>>>>>>>>>
