+1,checked list as follows: - verified the hash and signature - verified that there is no linkage errors - verified that the content of the pom is expected: the shaded dependencies are not exposed, the scope of the logging dependencies are runtime, etc.
Best, Jincheng Kenneth Knowles <k...@apache.org>于2020年1月10日 周五12:29写道: > +1 > > On Thu, Jan 9, 2020 at 4:03 PM Ahmet Altay <al...@google.com> wrote: > >> +1 >> >> On Thu, Jan 9, 2020 at 2:04 PM Pablo Estrada <pabl...@google.com> wrote: >> >>> +1 >>> >>> verified sha1 and md5 hashes. >>> >>> On Thu, Jan 9, 2020 at 10:28 AM Luke Cwik <lc...@google.com> wrote: >>> >>>> +1 >>>> >>>> I validated that no classes appeared outside of the >>>> org.apache.beam.vendor.grpc.v1p26p0 namespace and I also validated that the >>>> linkage checker listed no potential linkage errors. >>>> >>>> On Thu, Jan 9, 2020 at 10:25 AM Luke Cwik <lc...@google.com> wrote: >>>> >>>>> Please review the release of the following artifacts that we vendor: >>>>> * beam-vendor-grpc-1_26_0 >>>>> >>>>> Hi everyone, >>>>> Please review and vote on the release candidate #1 for the version >>>>> 0.1, as follows: >>>>> [ ] +1, Approve the release >>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>> >>>>> >>>>> The complete staging area is available for your review, which includes: >>>>> * the official Apache source release to be deployed to dist.apache.org >>>>> [1], which is signed with the key with >>>>> fingerprint EAD5DE293F4A03DD2E77565589E68A56E371CCA2 [2], >>>>> * all artifacts to be deployed to the Maven Central Repository [3], >>>>> * commit hash "e60d49bdf1ed85e8f3efa1da784227f381a9e085" [4], >>>>> >>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>> approval, with at least 3 PMC affirmative votes. >>>>> >>>>> Thanks, >>>>> Release Manager >>>>> >>>>> [1] https://dist.apache.org/repos/dist/dev/beam/vendor/ >>>>> [2] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>> [3] >>>>> https://repository.apache.org/content/repositories/orgapachebeam-1089/ >>>>> [4] >>>>> https://github.com/apache/beam/commit/e60d49bdf1ed85e8f3efa1da784227f381a9e085 >>>>> >>>> -- Best, Jincheng ------------- Twitter: https://twitter.com/sunjincheng121 -------------