On Tue, Mar 3, 2020 at 11:53 AM Chad Dombrova <chad...@gmail.com> wrote:
> >>> +1. Also would not running dmypy would require all contributors to run a >> process all the time? I do not know if this is desired by existing >> contributors, and I am not sure if it will be friendly to new contributors. >> > > Pre-commit git hooks are completely opt-in. Developers who choose not to > use them will simply continue doing what they do now. The Jenkins jobs > remain the only gatekeeper that really matters. But as a developer I'd > rather get all my linting and mypy checks done in a second each time I > commit, so that I know that the Jenkins lint job will succeed when I push > up my changes. Plus there's a lot of overhead running the lint jobs via > tox. > > Also note that even after you've setup the pre-commit hook in git, you can > opt out for a specific commit by passing -n to git commit. > OK, this sounds fine, if it will be completely optional and would not require any effort from new contributors to opt-out. This probably does not apply yet, does optional mean that opting-in for all or none of the precommit hooks? Would contributors have a choice of which pre-commits they can opt-in too?
