Yes, it seems like we probably have redundancy. Based on https://github.com/apache/beam/pull/9210#discussion_r315899335 it sounds like you added the ZetaSQL precommit when the SQL precommit was run as part of the Java precommit. Since then, the SQL precommit was separated from Java. It makes sense to me to have all the SQL tests be one precommit.
I have done some looking to see if we can exclude the SQL tests from the basic Java precommit (which calls "buildDependents") but I have not figured it out. Kenn On Tue, Jul 28, 2020 at 4:13 PM Rui Wang <ruw...@google.com> wrote: > Hi community, > > I observed that when there is a BeamSQL related PR, there will be four > precommits: SQL precommit, JavaBeamZetaSQL Precommit, and their Java11 > version. It turns out that SQL precommit will run tests from the Beam > ZetaSQL module. > > Thus we can remove JavaBeamZetaSQL and JavaBeamZetaSQLJava11 precommits > while still keeping the same level of testing on BeamSQL PRs. > > Do you agree? Does anyone know what is the right order of operations to > remove a precommit from Beam? > > > > -Rui >
