On Thu, Jan 7, 2021 at 3:35 PM Brian Hulette <bhule...@google.com> wrote:
> > > On Thu, Jan 7, 2021 at 2:00 PM Ahmet Altay <al...@google.com> wrote: > >> >> >> On Thu, Jan 7, 2021 at 12:25 PM Kyle Weaver <kcwea...@google.com> wrote: >> >>> I repro'd this by running "./gradlew :rat". If I understand correctly, >>> these are all Hugo dependencies that are downloaded automatically. I looked >>> at a few of them and they do have licenses, but I guess rat just doesn't >>> recognize them for whatever reason. >>> >> >> Do we know why precommits are not failing? They are running rat. And what >> changed recently? >> > > These are build files that only exist if you've built the website. So they > don't exist for the rat precommit > > >> >>> >>> The rat task is supposed to ignore everything in beam/.gitignore [1], >>> but the website directory has its own .gitignore [2]. The website's >>> .gitignore includes www/node_modules. I don't think there's really a need >>> for the website to have its own .gitignore, so one potential fix would be >>> to move the website .gitignore rules into the root one. >>> >> >> Merging gitignores sounds good. Another option we could add rat >> exclusions using the second gitignore list as well. >> > >> >>> I filed a JIRA for this as well: >>> https://issues.apache.org/jira/browse/BEAM-11582. >>> >> >> Are you interested in doing one of the above things? :) >> > > I'll send a PR to merge the gitignores > Thank you. > > >> >> >>> >>> [1] >>> https://github.com/apache/beam/blob/30f9a607509940f78459e4fba847617399780246/build.gradle#L119 >>> [2] >>> https://github.com/apache/beam/blob/2ad28542ec051dac6ebb8f0c6ea0c1b86a70f2cf/website/.gitignore#L16 >>> >>> On Thu, Jan 7, 2021 at 9:50 AM Reuven Lax <re...@google.com> wrote: >>> >>>> My builds are failing recently, with complaints of 2445 license >>>> violations. It appears to be a bunch of website files, see below. Any idea >>>> what is happening here? >>>> >>>> Unapproved Licenses: >>>> /Users/relax/beam/website/www/node_modules/callsites/index.js >>>> /Users/relax/beam/website/www/node_modules/callsites/readme.md >>>> /Users/relax/beam/website/www/node_modules/reusify/test.js >>>> /Users/relax/beam/website/www/node_modules/reusify/README.md >>>> >>>> /Users/relax/beam/website/www/node_modules/reusify/benchmarks/reuseNoCodeFunction.js >>>> /Users/relax/beam/website/www/node_modules/reusify/benchmarks/fib.js >>>> >>>> /Users/relax/beam/website/www/node_modules/reusify/benchmarks/createNoCodeFunction.js >>>> /Users/relax/beam/website/www/node_modules/reusify/.coveralls.yml >>>> /Users/relax/beam/website/www/node_modules/reusify/reusify.js >>>> /Users/relax/beam/website/www/node_modules/reusify/.travis.yml >>>> /Users/relax/beam/website/www/node_modules/pretty-hrtime/.npmignore >>>> /Users/relax/beam/website/www/node_modules/pretty-hrtime/.jshintignore >>>> /Users/relax/beam/website/www/node_modules/pretty-hrtime/index.js >>>> /Users/relax/beam/website/www/node_modules/@types/color-name/README.md >>>> >>>
