Quite often, dependency upgrade to latest versions leads to either compilation 
errors or failed tests and it should be resolved manually or declined. Having 
this, maybe I miss something, but I don’t see what kind of advantages automatic 
upgrade will bring to us except that we don’t need to create a PR manually 
(which is a not big deal).

Regarding another issue - it’s already a problem, imho. Since we have a one 
Jira per package upgrade now and usually it “accumulates” all package upgrades 
and it’s not closed once upgrade is done, we don’t have a reliable way to 
notify in release notes about all dependency upgrades for current release. One 
of the way is to mention the package upgrade in CHANGES.md which seems not very 
relible because it's quite easy to forget to do. I’d prefer to have a dedicated 
Jira issue for every upgrade and it will be included into releases notes almost 
automatically.  

> On 16 Apr 2021, at 14:15, Ismaël Mejía <ieme...@gmail.com> wrote:
> 
> Hello,
> 
> Github has a bot that creates automatically Dependency Update PRs and
> report security issues called dependabot.
> 
> I was wondering if we should enable it for Beam. I tested it in my
> personal Beam fork and it seems to be working well, it created
> dependency updates for both Python and JS (website) dependencies.
> The bot seems to be having problems to understand our gradle
> dependency definitions for Java but that's something we can address in
> the future to benefit of the updates. Also it did not propose go-lang
> updates (probably for the same reason).
> 
> If the community agrees I will create a ticket for INFRA to enable it.
> We might be getting extra PRs (at the beginning) and we have to be
> cautious about updates that might have unintended consequences for
> example we should not merge non stable dependency updates (those
> ending on -rc1 or -beta on Java) that
> might be proposed or dependencies that committers are aware we should
> not update for example projects where their main stable version is not
> the most recent one like Hadoop or dependencies that do not support
> our ongoing language target version (e.g. Java 11 only deps).
> 
> Another issue is that these dependency updates might not get a JIRA
> associated with them so we need to decide if (1) we create one and
> rename/associate the PR with it, or (2) we just decide not to have
> JIRAs for dependency updates.
> 
> WDYT? other pros/cons that I can be missing?
> 
> Ismaël

Reply via email to