I honestly don't think the gradle conversion process has value to users. This is where we have them create a start project from maven and then switch to gradle? No one does this. No one uses maven archetypes, really. Except by copy/pasting our instructions.
I do think we could have commented out blocks in the sample project for a few runners. Eventually it gets out of hand. And it is hard to test. Perhaps people interested in particular runners will contribute this on a volunteer basis. Kenn On Tue, Mar 22, 2022 at 12:32 PM David Cavazos <[email protected]> wrote: > That would be indeed hard to maintain. Each sample would have to include a > lot of set up code to bring up the runner infrastructure, plus tests for > each one. > > For now I linked to the runners documentation where people can get > instructions on how to enable their runners. Ideally we would have a sample > for each runner, but I haven't had bandwidth for it. > > On Fri, Mar 4, 2022 at 7:05 PM David Huntsperger <[email protected]> > wrote: > >> Nice, David! >> >> I don't think it's super important if we use Groovy or Kotlin. I was >> going to update the docs to show the Kotlin DSL as part of a larger fix >> <https://issues.apache.org/jira/browse/BEAM-12770> -- our >> documented Gradle conversion process doesn't work for some of the runners. >> This brings up another question. How do we want to handle documentation for >> using various runners, now that we have this new minimal sample? One >> option would be to document adding dependencies for each supported runner. >> But that could get pretty hard to maintain if we have to document for each >> build system and each runner: "To add support for Flink in Maven, add the >> following line..." etc. >> >> On Fri, Mar 4, 2022 at 10:23 AM David Cavazos <[email protected]> >> wrote: >> >>> Here's the PR for the Java starter project: >>> https://github.com/apache/beam-starter-java/pull/1 >>> >>> The Gradle file is currently written in Groovy, do we want to change >>> that to Kotlin? If so, we can do that in a follow up PR so we can get this >>> merged sooner rather than later. >>> >>> On Thu, Mar 3, 2022 at 7:17 PM David Huntsperger < >>> [email protected]> wrote: >>> >>>> That's what I'm planning on. After the new starter repos are available, >>>> we'll rewrite the quickstarts. I'm just fixing stuff up in the meantime... >>>> >>>> On Thu, Mar 3, 2022 at 5:02 PM Kenneth Knowles <[email protected]> wrote: >>>> >>>>> I presume this whole page will go away and be replaced by a use of the >>>>> new starter repos, no? >>>>> >>>>> On Thu, Mar 3, 2022 at 11:02 AM David Cavazos <[email protected]> >>>>> wrote: >>>>> >>>>>> Sounds good to me too. >>>>>> >>>>>> On Thu, Mar 3, 2022 at 9:00 AM Luke Cwik <[email protected]> wrote: >>>>>> >>>>>>> Sounds good. >>>>>>> >>>>>>> On Thu, Mar 3, 2022 at 6:46 AM David Huntsperger < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hey folks, >>>>>>>> >>>>>>>> I want to improve the convert-to-Gradle steps in the Java >>>>>>>> quickstart <https://beam.apache.org/get-started/quickstart-java/>. >>>>>>>> Right now, we only document Maven-to-Gradle conversion for the >>>>>>>> DirectRunner. >>>>>>>> >>>>>>>> The current conversion steps use Groovy. I am inclined to update >>>>>>>> this to use Kotlin. I think that's the general preference on this >>>>>>>> project. >>>>>>>> >>>>>>>> Does anyone have concerns about this? Updating docs to show a >>>>>>>> Kotlin Gradle build? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> David >>>>>>>> >>>>>>>
