+1 to make it “on" by default with mentioning that on Contribution Guide.

I recall for one PR that it took me some time to realise why it was failing on 
Jenkins and not locally because of this different behaviour. 

—
Alexey

> On 20 Oct 2022, at 00:51, Kenneth Knowles <[email protected]> wrote:
> 
> Hi all,
> 
> Some time ago we turned off checker framework locally by default, and only 
> turn it on with `-PenableCheckerFramework` and also on Jenkins.
> 
> My opinion is that this causes more headache than it solves, by delaying 
> finding out about errors. The increased compilation time of checkerframework 
> is real. But during iteration almost every step of a compile is cached so it 
> only matters specifically for :sdks:java:core. My take is that anyone editing 
> that is probably experienced enough with Beam to know they can turn it off. 
> So I propose we turn it on by default, with the option to disable it.
> 
> Kenn

Reply via email to