+1 (non-binding). Tested with https://github.com/GoogleCloudPlatform/DataflowTemplates (Java SDK 11, Dataflow Runner using both legacy and v2).
Thanks Kenn! On Wed, Oct 4, 2023 at 3:03 PM Robert Bradshaw via dev <dev@beam.apache.org> wrote: > +1 (binding) > > Verified artifacts and signatures and tested a simple python pipeline in a > fresh environment with a wheel. > > On Wed, Oct 4, 2023 at 8:05 AM Ritesh Ghorse via dev <dev@beam.apache.org> > wrote: > >> +1 (non-binding) validated Go SDK quickstart and Python Streaming >> quickstart on Dataflow runner. >> >> Thanks! >> >> On Tue, Oct 3, 2023 at 5:40 PM XQ Hu via dev <dev@beam.apache.org> wrote: >> >>> +1 (non-binding). Tested the simple dataflow ML starter job with >>> https://github.com/google/dataflow-ml-starter/actions/runs/6397130175/job/17364408813 >>> . >>> >>> On Tue, Oct 3, 2023 at 2:29 PM Danny McCormick via dev < >>> dev@beam.apache.org> wrote: >>> >>>> All Beam Python versions 2.50 and greater run exclusively on Dataflow >>>> runner v2, so we don't need to test v1 anymore. I'll delete those rows from >>>> the spreadsheet >>>> >>>> On Tue, Oct 3, 2023 at 2:25 PM Svetak Sundhar <svetaksund...@google.com> >>>> wrote: >>>> >>>>> +1 Non Binding >>>>> >>>>> Tested Python Direct Runner and Dataflow Runner as well. >>>>> >>>>> On the spreadsheet, I came across "Dataflow v1 (until 2.49.0, >>>>> inclusive)", and do not fully understand what this means. >>>>> >>>>> Does this mean >>>>> (1) we shouldn't be testing on Dataflow runner v1 for releases after >>>>> 2.49 or >>>>> (2) make sure we test on runner v1 for this release? >>>>> >>>>> Thanks in advance for the clarification, >>>>> >>>>> >>>>> >>>>> Svetak Sundhar >>>>> >>>>> Data Engineer >>>>> s <nellywil...@google.com>vetaksund...@google.com >>>>> >>>>> >>>>> >>>>> On Tue, Oct 3, 2023 at 2:14 PM Danny McCormick via dev < >>>>> dev@beam.apache.org> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> Tested python/ML execution with >>>>>> https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/run_inference_huggingface.ipynb >>>>>> (interactive runner) and >>>>>> https://github.com/apache/beam/blob/master/examples/notebooks/beam-ml/automatic_model_refresh.ipynb >>>>>> (Dataflow runner). >>>>>> >>>>>> Thanks, >>>>>> Danny >>>>>> >>>>>> On Tue, Oct 3, 2023 at 1:58 PM Kenneth Knowles <k...@apache.org> >>>>>> wrote: >>>>>> >>>>>>> Hi everyone, >>>>>>> >>>>>>> Please review and vote on the release candidate #1 for the version >>>>>>> 2.51.0, as follows: >>>>>>> >>>>>>> [ ] +1, Approve the release >>>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>>> >>>>>>> Reviewers are encouraged to test their own use cases with the >>>>>>> release candidate, and vote +1 if no issues are found. Only PMC member >>>>>>> votes will count towards the final vote, but votes from all community >>>>>>> members is encouraged and helpful for finding regressions; you can >>>>>>> either >>>>>>> test your own use cases or use cases from the validation sheet [10]. >>>>>>> >>>>>>> The complete staging area is available for your review, which >>>>>>> includes: >>>>>>> >>>>>>> - GitHub Release notes [1], >>>>>>> - the official Apache source release to be deployed to >>>>>>> dist.apache.org [2], which is signed with the key with >>>>>>> fingerprint FFFFFFFF [3], >>>>>>> - all artifacts to be deployed to the Maven Central Repository >>>>>>> [4], >>>>>>> - source code tag "v1.2.3-RC3" [5], >>>>>>> - website pull request listing the release [6], the blog post >>>>>>> [6], and publishing the API reference manual [7]. >>>>>>> - Java artifacts were built with Gradle GRADLE_VERSION and >>>>>>> OpenJDK/Oracle JDK JDK_VERSION. >>>>>>> - Python artifacts are deployed along with the source release to >>>>>>> the dist.apache.org [2] and PyPI[8]. >>>>>>> - Go artifacts and documentation are available at pkg.go.dev [9] >>>>>>> - Validation sheet with a tab for 1.2.3 release to help with >>>>>>> validation [10]. >>>>>>> - Docker images published to Docker Hub [11]. >>>>>>> - PR to run tests against release branch [12]. >>>>>>> >>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>>>> majority approval, with at least 3 PMC affirmative votes. >>>>>>> >>>>>>> For guidelines on how to try the release in your projects, check out >>>>>>> our blog post at https://beam.apache.org/blog/validate-beam-release/ >>>>>>> . >>>>>>> >>>>>>> Thanks, >>>>>>> Kenn >>>>>>> >>>>>>> [1] https://github.com/apache/beam/milestone/15 >>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.51.0 >>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>>> [4] >>>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1356/ >>>>>>> [5] https://github.com/apache/beam/tree/v2.51.0-RC1 >>>>>>> [6] https://github.com/apache/beam/pull/28800 >>>>>>> [7] https://github.com/apache/beam-site/pull/649 >>>>>>> [8] https://pypi.org/project/apache-beam/2.51.0rc1/ >>>>>>> [9] >>>>>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.51.0-RC1/go/pkg/beam >>>>>>> [10] >>>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=437054928 >>>>>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>>>>> [12] https://github.com/apache/beam/pull/28663 >>>>>>> >>>>>>
