Thank you, Bruno! In that case, I will close this vote and we will move to an RC2.
On Fri, Dec 22, 2023 at 12:06 PM Bruno Volpato <bvolp...@google.com> wrote: > -1 > > Had issues using 2.53.0 rc1 on > https://github.com/GoogleCloudPlatform/DataflowTemplates: > DataflowTemplates/pull/1233/checks?check_run_id=19897484522 > <https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1233/checks?check_run_id=19897484522> > > This seems to be the root cause: > > java.lang.NoClassDefFoundError: > com/google/api/services/storage/model/Bucket$ObjectRetention > at > com.google.cloud.storage.JsonConversions.<init>(JsonConversions.java:120) > at > com.google.cloud.storage.JsonConversions.<clinit>(JsonConversions.java:89) > at com.google.cloud.storage.Conversions.json(Conversions.java:33) > at com.google.cloud.storage.StorageImpl.<clinit>(StorageImpl.java:109) > > > Apparently libraries-bom was updated at > https://github.com/apache/beam/pull/29641 and brings a new version of > google-cloud-storage, but Beam has pinned a specific dependency to an older > version, which missed important classes and was not bumped: > https://github.com/apache/beam/blob/release-2.53.0/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L737 > > I proposed https://github.com/apache/beam/pull/29864 (+ cherry-pick to > release branch https://github.com/apache/beam/pull/29865). > > > Thanks! > Best, > Bruno > > > On Fri, Dec 22, 2023 at 9:29 AM XQ Hu via dev <dev@beam.apache.org> wrote: > >> +1 (non-binding) >> >> Tested apache-beam[gcp]==2.53.0rc1 with a simple RunInference pipeline >> using Dataflow Runner: >> https://github.com/google/dataflow-ml-starter/actions/runs/7296067726/job/19883348692 >> >> On Thu, Dec 21, 2023 at 4:30 PM Danny McCormick via dev < >> dev@beam.apache.org> wrote: >> >>> +1 (non-binding) >>> >>> Tested against a few Beam ML notebooks using the direct runner and >>> Dataflow runner. >>> >>> Thanks, >>> Danny >>> >>> On Thu, Dec 21, 2023 at 3:50 PM Jack McCluskey via dev < >>> dev@beam.apache.org> wrote: >>> >>>> Happy holidays everyone, >>>> >>>> Please review and vote on the release candidate #1 for the version >>>> 2.53.0, as follows: >>>> >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> Reviewers are encouraged to test their own use cases with the release >>>> candidate, and vote +1 if no issues are found. Only PMC member votes will >>>> count towards the final vote, but votes from all community members are >>>> encouraged and helpful for finding regressions; you can either test your >>>> own use cases [13] or use cases from the validation sheet [10]. >>>> >>>> The complete staging area is available for your review, which includes: >>>> * GitHub Release notes [1], >>>> * the official Apache source release to be deployed to dist.apache.org >>>> [2], which is signed with the key with fingerprint DF3CBA4F3F4199F4 >>>> (D20316F712213422 if automated) [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag "v1.2.3-RC3" [5], >>>> * website pull request listing the release [6], the blog post [6], and >>>> publishing the API reference manual [7]. >>>> * Python artifacts are deployed along with the source release to the >>>> dist.apache.org [2] and PyPI[8]. >>>> * Go artifacts and documentation are available at pkg.go.dev [9] >>>> * Validation sheet with a tab for 2.53.0 release to help with >>>> validation [10]. >>>> * Docker images published to Docker Hub [11]. >>>> * PR to run tests against release branch [12]. >>>> >>>> The vote will be open for at least 72 hours. It is adopted by majority >>>> approval, with at least 3 PMC affirmative votes. >>>> >>>> For guidelines on how to try the release in your projects, check out >>>> our RC testing guide [13]. >>>> >>>> Given the time of year I'm anticipating validating this RC to take >>>> longer than is typical for a Beam release. I won't be considering tomorrow >>>> or Monday towards the minimum voting period. As of right now the only >>>> remaining internal work is to publish legacy Java containers for Dataflow, >>>> which is in-progress and should be done this evening. >>>> >>>> I hope everyone has a relaxing end to 2023! >>>> >>>> Thanks, >>>> >>>> Jack McCluskey >>>> >>>> [1] https://github.com/apache/beam/milestone/17 >>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.53.0/ >>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> [4] >>>> https://repository.apache.org/content/repositories/orgapachebeam-1364/ >>>> [5] https://github.com/apache/beam/tree/v2.53.0-RC1 >>>> [6] https://github.com/apache/beam/pull/29856 >>>> [7] https://github.com/apache/beam-site/pull/656 >>>> [8] https://pypi.org/project/apache-beam/2.53.0rc1/ >>>> [9] >>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.53.0-RC1/go/pkg/beam >>>> [10] >>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1290249774 >>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>> [12] https://github.com/apache/beam/pull/29758 >>>> [13] >>>> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md >>>> >>>> -- >>>> >>>> >>>> Jack McCluskey >>>> SWE - DataPLS PLAT/ Dataflow ML >>>> RDU >>>> jrmcclus...@google.com >>>> >>>> >>>>
