Thanks, Danny. +1
Verified Python pipelines on Dataflow, checked that released containers include fixes for a regression in GRPC IO that affected last release. On Wed, May 1, 2024 at 11:30 AM Danny McCormick <dannymccorm...@google.com> wrote: > I added https://github.com/apache/beam/pull/31038#issuecomment-2088879104 > triaging > the issues. The JPMS ones do seem to have been from the Dataflow containers > not being published, they succeeded on retry. The remaining issues > generally seem to be flakes or infrastructure issues. > > Thanks, > Danny > > On Wed, May 1, 2024 at 1:42 PM Danny McCormick <dannymccorm...@google.com> > wrote: > >> I'll go through and triage/rekick off some Dataflow suites and summarize >> the results in the PR. The JPMS ones (and possibly others) might be because >> I hadn't published Dataflow containers yet when I ran them, the log isn't >> helpful so I'll try to capture the actual job which failed. >> >> Thanks, >> Danny >> >> On Wed, May 1, 2024 at 1:05 PM Valentyn Tymofieiev via dev < >> dev@beam.apache.org> wrote: >> >>> What is the high-level summary of test failures on >>> https://github.com/apache/beam/pull/31038 - are all issues >>> preexisting/infra-related/already tracked? >>> >>> In particular, I noticed two failures in the Java JPMS test suite, which >>> I hadn't come across before. >>> >>> On Wed, May 1, 2024 at 8:16 AM Ritesh Ghorse via dev < >>> dev@beam.apache.org> wrote: >>> >>>> +1 (non-binding) >>>> >>>> Ran a few python pipelines on Direct and Dataflow runner >>>> >>>> Thanks! >>>> >>>> On Wed, May 1, 2024 at 10:00 AM Jeff Kinard via dev < >>>> dev@beam.apache.org> wrote: >>>> >>>>> +1 (non-binding) >>>>> >>>>> Validated Dataflow YamlTemplate using Java and Python transforms >>>>> (xlang) and several Beam YAML tests. >>>>> >>>>> Thanks, >>>>> Jeff >>>>> >>>>> On Sat, Apr 27, 2024 at 7:42 AM Danny McCormick via dev < >>>>> dev@beam.apache.org> wrote: >>>>> >>>>>> Hi everyone, >>>>>> Please review and vote on the release candidate #2 for the version >>>>>> 2.56.0, as follows: >>>>>> [ ] +1, Approve the release >>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>> >>>>>> Reviewers are encouraged to test their own use cases with the release >>>>>> candidate, and vote +1 if no issues are found. Only PMC member votes will >>>>>> count towards the final vote, but votes from all community members is >>>>>> encouraged and helpful for finding regressions; you can either test your >>>>>> own use cases [13] or use cases from the validation sheet [10]. >>>>>> >>>>>> The complete staging area is available for your review, which >>>>>> includes: >>>>>> * GitHub Release notes [1], >>>>>> * the official Apache source release to be deployed to >>>>>> dist.apache.org [2], which is signed with the key with fingerprint >>>>>> D20316F712213422 [3], >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>> * source code tag "v2.56.0-RC2" [5], >>>>>> * website pull request listing the release [6], the blog post [6], >>>>>> and publishing the API reference manual [7]. >>>>>> * Python artifacts are deployed along with the source release to the >>>>>> dist.apache.org [2] and PyPI[8]. >>>>>> * Go artifacts and documentation are available at pkg.go.dev [9] >>>>>> * Validation sheet with a tab for 2.56.0 release to help with >>>>>> validation [10]. >>>>>> * Docker images published to Docker Hub [11]. >>>>>> * PR to run tests against release branch [12]. >>>>>> >>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>>> majority approval, with at least 3 PMC affirmative votes. >>>>>> >>>>>> For guidelines on how to try the release in your projects, check out >>>>>> our RC testing guide [13]. >>>>>> >>>>>> Thanks, >>>>>> Danny >>>>>> >>>>>> [1] https://github.com/apache/beam/milestone/20 >>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.56.0/ >>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>>>> [4] >>>>>> https://repository.apache.org/content/repositories/orgapachebeam-1377/ >>>>>> [5] https://github.com/apache/beam/tree/v2.56.0-RC2 >>>>>> [6] https://github.com/apache/beam/pull/31094 >>>>>> [7] https://github.com/apache/beam-site/pull/665 >>>>>> [8] https://pypi.org/project/apache-beam/2.56.0rc2/ >>>>>> [9] >>>>>> https://pkg.go.dev/github.com/apache/beam/sdks/v2@v2.56.0-RC2/go/pkg/beam >>>>>> [10] >>>>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1992402651 >>>>>> [11] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>>>> [12] https://github.com/apache/beam/pull/31038 >>>>>> [13] >>>>>> https://github.com/apache/beam/blob/master/contributor-docs/rc-testing-guide.md >>>>>> >>>>>