+1 I'd treat this as an official vote on this procedural matter.
On Tue, Nov 8, 2016 at 6:55 AM, Mukul Jain <muk...@gmail.com> wrote: > +1 > > Awesome work Thomas! More runner choices the better. > > Best > Mukul > > Sent from my iPhone > > > On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > +1 > > > > Great work Thomas !! > > > > Regards > > JB > > > > > > > >> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <t...@apache.org> wrote: > >> Hi, > >> > >> As per previous discussion [1], I would like to propose to merge the > >> apex-runner branch into master. The runner satisfies the criteria > >> outlined > >> in [2] and merging it to master will give more visibility to other > >> contributors and users. > >> > >> Specifically the Apex runner addresses: > >> > >> - Have at least 2 contributors interested in maintaining it, and 1 > >> committer interested in supporting it: *I'm going to sign up for the > >> support and there are more folks interested. Some have already > >> contributed > >> and helped with PR reviews, others from the Apex community have > >> expressed > >> interest [3].* > >> - Provide both end-user and developer-facing documentation: *Runner > >> has > >> README, capability matrix, Javadoc. Planning to add it to the tutorial > >> later.* > >> - Have at least a basic level of unit test coverage: *Has 30 runner > >> specific tests and passes all Beam RunnableOnService tests.* > >> - Run all existing applicable integration tests with other Beam > >> components and create additional tests as appropriate: * Enabled runner > >> for examples integration tests in the same way as other runners.* > >> - Be able to handle a subset of the model that address a significant > >> set of > >> use cases (aka. ‘traditional batch’ or ‘processing time > >> streaming’): *Passes > >> RunnableOnService without exclusions and example IT.* > >> - Update the capability matrix with the current status: *Done.* > >> - Add a webpage under learn/runners: *Same "TODO" page as other runners > >> added to site.* > >> > >> The PR for the merge: > >> https://github.com/apache/incubator-beam/pull/1305 > >> > >> (There are intermittent test failures in individual Travis runs that > >> are > >> unrelated to the runner.) > >> > >> Thanks, > >> Thomas > >> > >> [1] > >> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648 > 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E > >> > >> [2] > >> http://beam.apache.org/contribute/contribution-guide/#feature-branches > >> > >> [3] > >> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf > 4d3d4e41de4249547 > >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E> > >> 130691d52@%3Cdev.apex.apache.org%3E > >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E> >
