Hi,

PAssertTest#runExpectingAssertionFailure() contains the following block:

try {
  pipeline.run();
} catch (AssertionError exc) {
  return exc;
}

I was wondering if in some cases this might not produce the desired effect,
particularly if the run() method returns before the pipeline has ended.
While some runners may choose to inherently wait for the pipeline to end in
their run() method (e.g., DirectRunner if options.isBlockOnRun() is set to
true), this seems to be an optional behavior that may be absent in other
runners.

Is this indeed an issue (in which case the above will benefit from calling
waitUntilFinish)?

Regards,
Stas

Reply via email to