----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9166/#review15890 -----------------------------------------------------------
bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/shell/Shell.groovy <https://reviews.apache.org/r/9166/#comment34163> It's worth noting that this is a backwards incompatible change. Any code that presently calls exec() and hasn't been updated will now break because now it's first parameter being sent is being treated as a time out argument. - Mark Grover On Jan. 30, 2013, 8:35 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9166/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2013, 8:35 p.m.) > > > Review request for bigtop and Roman Shaposhnik. > > > Description > ------- > > Added new methods which can execute a script for a specified timeout and can > also execute in the background. > > > This addresses bug BIGTOP-835. > https://issues.apache.org/jira/browse/BIGTOP-835 > > > Diffs > ----- > > > bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/shell/Shell.groovy > ae3da68 > > bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/shell/ShellTest.groovy > 1571e10 > > Diff: https://reviews.apache.org/r/9166/diff/ > > > Testing > ------- > > Added unit tests for new functionality. Current unit tests pass > > > Thanks, > > Hari Shreedharan > >
