[ 
https://issues.apache.org/jira/browse/BIGTOP-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567308#comment-13567308
 ] 

Johnny Zhang commented on BIGTOP-835:
-------------------------------------

I think most of the tests in Bigtop uses @Test(timeout=???L) to control the 
timeout of the testcase. In this case, execWithTimeout seems redundant for me. 
Plus, it will be equipment only if it can print meaningful error message.

I also agree with cos that introducing those methods kind of confuse the 
concepts. Maybe we can move those implementation to another class. Also, more 
error message will be helpful.
                
> The shell exec method must have variants which have timeout and can run in 
> background
> -------------------------------------------------------------------------------------
>
>                 Key: BIGTOP-835
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-835
>             Project: Bigtop
>          Issue Type: Bug
>            Reporter: Hari Shreedharan
>         Attachments: BIGTOP-835-1.patch, BIGTOP-835-2.patch, 
> BIGTOP-835-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to