> On Jan. 31, 2013, 2:03 a.m., Mark Grover wrote: > > bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/shell/ShellTest.groovy, > > line 54 > > <https://reviews.apache.org/r/9166/diff/2/?file=253628#file253628line54> > > > > Wouldn't a better test to be have something that never finishes (like > > an infinite loop) and have a timeout on that? Test would succeed asserting > > if it finished (possibly within a certain time).
Agreed, but it is not really required - as long as it is predictable. > On Jan. 31, 2013, 2:03 a.m., Mark Grover wrote: > > bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/shell/ShellTest.groovy, > > line 58 > > <https://reviews.apache.org/r/9166/diff/2/?file=253628#file253628line58> > > > > Why 4000? Could you please add a comment stating so? Just to ensure it is less than 5 seconds (which is what the process sleeps for). Accounting for scheduling irregularities, it is safe to make sure it didnt take the full 5 seconds. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9166/#review15917 ----------------------------------------------------------- On Jan. 31, 2013, 1:37 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9166/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2013, 1:37 a.m.) > > > Review request for bigtop and Roman Shaposhnik. > > > Description > ------- > > Added new methods which can execute a script for a specified timeout and can > also execute in the background. > > > This addresses bug BIGTOP-835. > https://issues.apache.org/jira/browse/BIGTOP-835 > > > Diffs > ----- > > > bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/shell/Shell.groovy > ae3da68 > > bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/shell/ShellTest.groovy > 1571e10 > > Diff: https://reviews.apache.org/r/9166/diff/ > > > Testing > ------- > > Added unit tests for new functionality. Current unit tests pass > > > Thanks, > > Hari Shreedharan > >
