-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10778/
-----------------------------------------------------------

(Updated April 25, 2013, 5:36 p.m.)


Review request for bigtop.


Changes
-------

Wrong patch - hadn't fixed the case of %{SOURCE#} references in the spec file.


Description
-------

Intended to be applied over BIGTOP-732. HBase currently has 3 
distribution-specific init script templates, but this patch combines them all 
the use one template shared with other services. This reduces maintenance 
overhead now, and will make it easier to migrate to SysV-init replacements in 
the future.


This addresses bug BIGTOP-936.
    https://issues.apache.org/jira/browse/BIGTOP-936


Diffs (updated)
-----

  bigtop-packages/src/common/hbase/hbase.svc PRE-CREATION 
  bigtop-packages/src/deb/hbase/install_init_scripts.sh f60059c 
  bigtop-packages/src/deb/hbase/service-init.d.tpl 9260c71 
  bigtop-packages/src/rpm/hbase/SOURCES/hbase.sh 3cdcea4 
  bigtop-packages/src/rpm/hbase/SOURCES/hbase.sh.suse 5452e00 
  bigtop-packages/src/rpm/hbase/SPECS/hbase.spec d698bdf 
  bigtop-packages/src/templates/init.d.tmpl 61db5d5 

Diff: https://reviews.apache.org/r/10778/diff/


Testing
-------

Built and installed on Ubuntu 12, RHEL 6 and SLES 11. Started, stopped, 
restarted and checked status multiple times. Checked pid files, logs, process 
behavior, return values and environment for consistency.


Thanks,

Sean Mackrory

Reply via email to