[ 
https://issues.apache.org/jira/browse/BIGTOP-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714170#comment-13714170
 ] 

Mark Grover commented on BIGTOP-1031:
-------------------------------------

Hi Jay, thanks for contributing! It looks good to me. May I request you to 
provide a patch via {{git format-patch}}, please?

This the workflow I personally follow:
1. Ensure that you have all of your change as 1 commit which has the correct 
commit message - something like {{BIGTOP-1031: README has outdated/ambiguous 
information}}
2. Then run a command like: git format-patch HEAD^..HEAD --stdout > 
BIGTOP-1031.1.patch
3. Upload the BIGTOP-1031.1.patch file to this JIRA:-)

{{git format-patch}} works better for all of us because it's easy to attribute 
the commit to you in the git history since it contains your name and email 
address.
                
> README has outdated/ambiguous information
> -----------------------------------------
>
>                 Key: BIGTOP-1031
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1031
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 0.6.0
>         Environment: All
>            Reporter: jay vyas
>            Priority: Minor
>             Fix For: 0.7.0
>
>         Attachments: README.patch
>
>
> Readme has some incorrect/obsolete paths and the "packaging" example is 
> somewhat confusing since, in fact, "packaging" is a maven term as well as a 
> bigtop smoke.  Also, "cd" to the directory is unnecessary (just use mvn -f to 
> specify pom).  Also, add more examples.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to