[
https://issues.apache.org/jira/browse/BIGTOP-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757332#comment-13757332
]
Mark Grover commented on BIGTOP-1059:
-------------------------------------
I am +1 (with one minor nitpick below) and will wait for a day or so to commit
in case someone else has any concerns with it.
I would suggest, if you don't mind, to remove the comment regarding pig smoke
test not working with pig < 0.11. Technically, the tests only have been run
against the version of the component bundled in that version of Bigtop.
However, sometimes we have to make changes in test code to make them compatible
with the newer corresponding component version which may prevent them from
running with the old version. We try to avoid doing so as much as we can but if
someone really wanted to use tests with an older version of the component, they
could get the test code from an older branch of Bigtop and use that instead.
And, like always, thanks for contributing, Jay!
> Add path option for pig.jar to pig smoke pom.xml
> ------------------------------------------------
>
> Key: BIGTOP-1059
> URL: https://issues.apache.org/jira/browse/BIGTOP-1059
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Reporter: jay vyas
> Priority: Minor
> Attachments: BIGTOP-1059.1.patch
>
>
> The pig.jar path is hardcoded in the existing
> test-execution/smokes/pig/pom.xml file, which means that tarball based pig
> deployments or non-standard pig install locations cannot use the smoke test.
> Also, the pom.xml in test-execution/smokes could use a couple of small
> comments since it is different than the other test-executions as of this date
> (i.e. it depends on an external smoke rather than one created in
> test-artifacts).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
