[
https://issues.apache.org/jira/browse/BIGTOP-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837803#comment-13837803
]
Sean Mackrory commented on BIGTOP-1072:
---------------------------------------
Thanks for putting this patch together, Jay. I'm sorry it's taken a while to
get you some reviews. Here are my thoughts:
* I agree with Peter that we shouldn't limit ourselves to Fedora, but I don't
think we should wait to commit this until we can support the full complement of
distros (not what Peter was saying anyway, I don't think). Boxgrinder only
supported RedHat / CentOS well, but I would imagine a great next step here is
to add a bit of distro-aware logic to your provisioner and comment out the
other supported options for the base box in the Vagrantfile.
* Since the config directory is required, I would suggest creating it and
adding a .gitignore file or something to it so that git pays attention to it
and your patch creates it for users.
* My system errored out because the "host_name" property doesn't exist, and I
couldn't find documentation for it. Mistake?
* Since the cachier plugin doesn't necessarily come with Vagrant, I have a
slight preference toward disabling that by default. Maybe have it commented out
with an explanation of the benefits of installing that plugin and enabling it?
* I see you're installing OpenJDK. That's often what I use and I've never
personally run into problems, but just be aware that upstream Hadoop has always
recommend Oracle JDK (it did last I checked). Unfortunately we can't distribute
that so easily anymore, so I have no objection to using OpenJDK in this. Just
something to be aware of.
* I'm not sure if I like the idea of running a job on start-up. It's a nice
test, but I envisioned this as more of just providing a blank slate for people.
No objection, just thinking out loud.
I think this is really cool stuff. The provisioner is still running and I've
seen a couple of hiccups, but they look like my fault. I'll comment more later
today once I've done some more testing, but if you can resolve the cache,
host_name, and possibly the cashier issues I raised, then I'm pretty close to a
+1 here.
> Vagrant scripts for spinning up and "hydrating" bigtop vms
> -----------------------------------------------------------
>
> Key: BIGTOP-1072
> URL: https://issues.apache.org/jira/browse/BIGTOP-1072
> Project: Bigtop
> Issue Type: Bug
> Reporter: jay vyas
> Priority: Minor
> Attachments: BIGTOP-1072.1.patch
>
>
> Vagrant is a tool that spins up VMs for you and destroys them. The only real
> requirement it has is that a "base box" has been created before hand.
> At that point, you can install the VM using different provider hosts
> (kvm,virtualbox,etc...).
> The goal of vagrant is to unify VM environments for developers with
> production env. This is very similar to what bigtop aims at providing.
> Vagrant adds host/guest shared directories, static ips, and allthe other
> goodies that one has to configure manually, into vm provisioning in a vendor
> neutral fashion: Essentially giving a declarative API to VM creation.
> I would like to suggest that bigtop provides / maintains vagrant startup
> scripts that layer hadoop tools on top of a "base box" vm. This is slightly
> different than the current strategy which creates a full blown VM with hadoop
> on it. The vagrant approach provides a means for more developer
> customization of the vm artifacts being used without adding any real overhead
> (other than having vagrant installed and understanding the very simply
> vagrant recipe for creating a vm).
> Probably in the begining this could be complimentary to the boxgrinder
> created VMs, and over time, maybe people would migrated to using the vagrant
> provisioned VMs as they become more popular and use of vagrant gets more
> common in the community.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
