[
https://issues.apache.org/jira/browse/BIGTOP-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919980#comment-13919980
]
Konstantin Boudnik commented on BIGTOP-1239:
--------------------------------------------
Actually, I take it back. The change in the regexp isn't equivalent. Here's why:
- the change goes fro/to
{noformat}
hdfs://\w+[-.a-z0-9]*:[0-9]+
hdfs://\w+[-.a-z0-9]*[:[0-9]]?+
{noformat}
and that changes the semantic of the expression. The '+' sign should be inside.
And I think you'd be better off by using '(' and ')' instead of the square
brackets. So, final regexp should be something like
{noformat}
hdfs://\w+[-.a-z0-9]*(:[0-9]+)?
{noformat}
Otherwise the patch is good ;)
> TestCLI: make ports optional in regex comparators
> -------------------------------------------------
>
> Key: BIGTOP-1239
> URL: https://issues.apache.org/jira/browse/BIGTOP-1239
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: Dasha Boudnik
> Assignee: Dasha Boudnik
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1239.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The following is seen in a multi-node configuration in HA:
> {noformat}14/03/03 19:32:40 INFO cli.CLITestHelper:
> -------------------------------------------
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Test ID: [256]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Test Description:
> [mkdir: Test for NAMENODE path - creating a directory with the name of an
> already existing directory]
> 14/03/03 19:32:40 INFO cli.CLITestHelper:
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Test Commands: [-fs
> hdfs://myCluster -mkdir hdfs://myCluster/tmp/testcli_1393903659798/dir0]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Test Commands: [-fs
> hdfs://myCluster -mkdir hdfs://myCluster/tmp/testcli_1393903659798/dir0]
> 14/03/03 19:32:40 INFO cli.CLITestHelper:
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Cleanup Commands: [-fs
> hdfs://myCluster -rm -r hdfs://myCluster/tmp/testcli_1393903659798/dir0]
> 14/03/03 19:32:40 INFO cli.CLITestHelper:
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Comparator:
> [RegexpComparator]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Comparision result:
> [fail]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Expected output:
> [mkdir: `hdfs://\w+[-.a-z0-9]*:[0-9]+/tmp/testcli_1393903659798/dir0': File
> exists]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: Actual output:
> [mkdir: `hdfs://myCluster/tmp/testcli_1393903659798/dir0': File exists
> ]
> 14/03/03 19:32:40 INFO cli.CLITestHelper: {noformat}
> A couple dozen other tests fail for the same reason.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
