> On March 4, 2014, 3:07 a.m., Mark Grover wrote: > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy, > > line 77 > > <https://reviews.apache.org/r/18593/diff/1/?file=506544#file506544line77> > > > > Dead code, please take it out.
> On March 4, 2014, 3:07 a.m., Mark Grover wrote: > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy, > > line 169 > > <https://reviews.apache.org/r/18593/diff/1/?file=506544#file506544line169> > > > > Why take out a test? What if someone else's code somewhere uses this > > test? Is this something that just applies to HDFS and not to other HCFSs? took this out because it was a "bad " test (order dependant). > On March 4, 2014, 3:07 a.m., Mark Grover wrote: > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy, > > line 202 > > <https://reviews.apache.org/r/18593/diff/1/?file=506544#file506544line202> > > > > Where is "contents" coming from? Is it guaranteed to be there across > > file systems? contents come from the write statement > On March 4, 2014, 3:07 a.m., Mark Grover wrote: > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy, > > line 219 > > <https://reviews.apache.org/r/18593/diff/1/?file=506544#file506544line219> > > > > Is this guaranteed? I haven't read the cp spec but I would think the > > only guaranteed thing would be the return code. A better assert here would > > be to check if the destination exists and diff it with the source. > > > > Checking strings from output is a pretty hard to maintain and arguably > > a very strict assert. yes definetly gauranteed that ls will show files copied in. i think... am i missing something? - jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18593/#review36080 ----------------------------------------------------------- On March 4, 2014, 6:33 p.m., jay vyas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18593/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:33 p.m.) > > > Review request for bigtop. > > > Repository: bigtop > > > Description > ------- > > this patch makes bigtop fuse tests awesome :) > > > Diffs > ----- > > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hcfs/TestFuseHCFS.groovy > PRE-CREATION > > bigtop-tests/test-artifacts/hadoop/src/main/groovy/org/apache/bigtop/itest/hadoop/hdfs/TestFuseDFS.groovy > c42fb33 > > Diff: https://reviews.apache.org/r/18593/diff/ > > > Testing > ------- > > tested in a pseudodistributed VM. works. > > > Thanks, > > jay vyas > >
