[
https://issues.apache.org/jira/browse/BIGTOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924247#comment-13924247
]
Konstantin Boudnik commented on BIGTOP-1246:
--------------------------------------------
I think the patch is going too far. I believe the intention of the test is to
run some httpfs commands as a generic user via curl and then verify the codes
(that's where the bug needs to be fixed). However, removing shHDFS seems like
an overreach, as the cleanup needs to be done as the owner of the directories.
These two users can be different hence the need for two different shell
objects.
Your patch only needs to address the asserts part in lines 101, 111, 134, 145,
148
> Fix the shell-object bug in HttpFs smoke tests
> ----------------------------------------------
>
> Key: BIGTOP-1246
> URL: https://issues.apache.org/jira/browse/BIGTOP-1246
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Adam Kawa
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1246.1.patch
>
>
> [~jaoki] has identified a bug in HttpFs smoke tests, where a different shell
> object was used to verify the return code from the command, than the one that
> really executed this command:
> {code}
> 110 sh.exec("curl -i -X DELETE
> '$HTTPFS_PREFIX$testHttpFsFolder?user.name=$USERNAME&op=DELETE'");
> 111 assertTrue("curl command to delete a dir failed", shHDFS.getRet()
> == 0);
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
