[
https://issues.apache.org/jira/browse/BIGTOP-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120152#comment-14120152
]
Konstantin Boudnik commented on BIGTOP-1424:
--------------------------------------------
bq. -Dmaven.test.skip will not compile the test source code;
Honestly, not compiling the test code is the exact objective of the current
approach. Hive is a behemoth that takes just under 5-10 minutes to build. With
test code compilation it will what...? - 15 mins?
Besides, what's the value of compiling test code from an official release? If
Hive community allows a release with non-compilable test code - I'd say this is
the least problem on my list.
As for getting a test jar from the external repo: is it really a concern that
warrants increasing the build time?
> hive do-component-build should use skipTest instead of maven.test.skip
> ----------------------------------------------------------------------
>
> Key: BIGTOP-1424
> URL: https://issues.apache.org/jira/browse/BIGTOP-1424
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: stanley shi
>
> In the file bigtop-packages / src / common / hive / do-component-build, it is
> using
> -Dmaven.test.skip=true
> we should change to use
> -DskipTests
> The difference between these two:
> http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html
> -Dmaven.test.skip will not compile the test source code;
> -DskipTests will only skip the test;
> hive-service has dependency on hive-exec:
> {code}
> <dependency>
> <groupId>org.apache.hive</groupId>
> <artifactId>hive-exec</artifactId>
> <version>${project.version}</version>
> <scope>test</scope>
> <classifier>tests</classifier>
> </dependency>
> {code}
> without this fix, when build hive-service, it will get the hive-exec-test jar
> from apache maven repository instead of get what we just built.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
