[ 
https://issues.apache.org/jira/browse/BIGTOP-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127302#comment-14127302
 ] 

Mark Grover commented on BIGTOP-1264:
-------------------------------------

Thanks Wenwu!

2 comments:
{code}
-         cp $(BASE_DIR)/bigtop-packages/src/templates/init.d.tmpl debian && \
+         cp -r $(BASE_DIR)/bigtop-packages/src/templates/* debian && \
{code}
I'd really prefer if you selectively copy only the things you need from that 
directory. We may add more things later, and this may break it down the road.

{code}
+                               
--set-envvar=MAINTAINER="$(VENDOR)$(VENDOR_MAIL)" \
                                -uc -us -b
{code}
I thought there was a space between the VENDOR and the VENDOR_MAIL, no?

> make the DEBIAN file flexible Maintainer with variable substitutions
> --------------------------------------------------------------------
>
>                 Key: BIGTOP-1264
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1264
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: build, debian
>    Affects Versions: 0.8.0
>            Reporter: Wenwu Peng
>            Assignee: Wenwu Peng
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1264, BIGTOP-1264.1.patch
>
>
> Right now Maintainer is hardcoded,we need to make the DEBIAN file flexible 
> Maintainer with variable substitutions, split this jira from BIGTOP-1251 due 
> to debian have different variable substitutions with RPM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to